Linux clock framework development
 help / color / mirror / Atom feed
From: Akari Tsuyukusa <akkun11.open@gmail.com>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney@redhat.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Yassine Oudjana <y.oudjana@protonmail.com>,
	Richard Cochran <richardcochran@gmail.com>
Cc: "Laura Nao" <laura.nao@collabora.com>,
	"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Chen-Yu Tsai" <wenst@chromium.org>,
	"Akari Tsuyukusa" <akkun11.open@gmail.com>,
	"Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Uwe Kleine-König (The Capable Hub)"
	<u.kleine-koenig@baylibre.com>,
	"Nicolas Frattaroli" <nicolas.frattaroli@collabora.com>,
	"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
	"Haotian Zhang" <vulab@iscas.ac.cn>,
	"Kees Cook" <kees@kernel.org>,
	"Miles Chen" <miles.chen@mediatek.com>,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Sam Shih" <sam.shih@mediatek.com>,
	linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK),
	linux-kernel@vger.kernel.org (open list),
	linux-arm-kernel@lists.infradead.org (moderated
	list:ARM/Mediatek SoC support),
	linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
	SoC support),
	netdev@vger.kernel.org (open list:PTP HARDWARE CLOCK
	SUPPORT:Keyword:(?:b|_)ptp(?:b|_)),
	stable@vger.kernel.org
Subject: [PATCH 09/32] clk: mediatek: Add cpumux support to common probe/remove helpers
Date: Mon,  3 Aug 2026 23:16:36 +0900	[thread overview]
Message-ID: <20260803141659.559129-10-akkun11.open@gmail.com> (raw)
In-Reply-To: <20260803141659.559129-1-akkun11.open@gmail.com>

Extend __mtk_clk_simple_probe() and __mtk_clk_simple_remove() to
support cpumux clocks. This reduces boilerplate code in drivers for
SoCs that require cpumux registration, such as mt6795-infracfg.

Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
---
 drivers/clk/mediatek/clk-mtk.c | 18 +++++++++++++++++-
 drivers/clk/mediatek/clk-mtk.h |  2 ++
 2 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c
index 3dfdd3a422f8..8148c21e6099 100644
--- a/drivers/clk/mediatek/clk-mtk.c
+++ b/drivers/clk/mediatek/clk-mtk.c
@@ -19,6 +19,7 @@
 #include "clk-mtk.h"
 #include "clk-gate.h"
 #include "clk-mux.h"
+#include "clk-cpumux.h"
 
 const struct mtk_gate_regs cg_regs_dummy = { 0, 0, 0 };
 EXPORT_SYMBOL_GPL(cg_regs_dummy);
@@ -513,6 +514,7 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev,
 	num_clks = mcd->num_clks + mcd->num_composite_clks;
 	num_clks += mcd->num_fixed_clks + mcd->num_factor_clks;
 	num_clks += mcd->num_mux_clks + mcd->num_divider_clks;
+	num_clks += mcd->num_cpumuxes;
 
 	clk_data = mtk_alloc_clk_data(num_clks);
 	if (!clk_data) {
@@ -542,6 +544,13 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev,
 			goto unregister_factors;
 	}
 
+	if (mcd->cpumuxes) {
+		r = mtk_clk_register_cpumuxes(&pdev->dev, node, mcd->cpumuxes,
+					      mcd->num_cpumuxes, clk_data);
+		if (r)
+			goto unregister_muxes;
+	}
+
 	if (mcd->composite_clks) {
 		/* We don't check composite_lock because it's optional */
 		r = mtk_clk_register_composites(&pdev->dev,
@@ -549,7 +558,7 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev,
 						mcd->num_composite_clks,
 						base, mcd->clk_lock, clk_data);
 		if (r)
-			goto unregister_muxes;
+			goto unregister_cpumuxes;
 	}
 
 	if (mcd->divider_clks) {
@@ -605,6 +614,10 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev,
 	if (mcd->composite_clks)
 		mtk_clk_unregister_composites(mcd->composite_clks,
 					      mcd->num_composite_clks, clk_data);
+unregister_cpumuxes:
+	if (mcd->cpumuxes)
+		mtk_clk_unregister_cpumuxes(mcd->cpumuxes,
+					    mcd->num_cpumuxes, clk_data);
 unregister_muxes:
 	if (mcd->mux_clks)
 		mtk_clk_unregister_muxes(mcd->mux_clks,
@@ -643,6 +656,9 @@ static void __mtk_clk_simple_remove(struct platform_device *pdev,
 	if (mcd->composite_clks)
 		mtk_clk_unregister_composites(mcd->composite_clks,
 					      mcd->num_composite_clks, clk_data);
+	if (mcd->cpumuxes)
+		mtk_clk_unregister_cpumuxes(mcd->cpumuxes,
+					    mcd->num_cpumuxes, clk_data);
 	if (mcd->mux_clks)
 		mtk_clk_unregister_muxes(mcd->mux_clks,
 					 mcd->num_mux_clks, clk_data);
diff --git a/drivers/clk/mediatek/clk-mtk.h b/drivers/clk/mediatek/clk-mtk.h
index 5417b9264e6d..02fab4b166f2 100644
--- a/drivers/clk/mediatek/clk-mtk.h
+++ b/drivers/clk/mediatek/clk-mtk.h
@@ -252,6 +252,8 @@ struct mtk_clk_desc {
 	size_t num_factor_clks;
 	const struct mtk_mux *mux_clks;
 	size_t num_mux_clks;
+	const struct mtk_composite *cpumuxes;
+	size_t num_cpumuxes;
 	const struct mtk_clk_rst_desc *rst_desc;
 	spinlock_t *clk_lock;
 	bool shared_io;
-- 
2.55.0


  parent reply	other threads:[~2026-08-03 14:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 14:16 [PATCH 00/32] clk: mediatek: Migrate to common probe/remove helpers and fix memory leaks Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 01/32] clk: mediatek: mt2712: fix memory leak on module removal Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 02/32] clk: mediatek: mt6795: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 03/32] clk: mediatek: mt7622: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 04/32] clk: mediatek: mt8135: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 05/32] clk: mediatek: mt8173: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 06/32] clk: mediatek: mt8192: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 07/32] clk: mediatek: mt6735: Add missing MODULE_DEVICE_TABLE() Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 08/32] clk: mediatek: mt7988-apmixed: " Akari Tsuyukusa
2026-08-03 14:16 ` Akari Tsuyukusa [this message]
2026-08-03 14:16 ` [PATCH 10/32] clk: mediatek: Add PLL support to common probe/remove helpers Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 11/32] clk: mediatek: Add auto-population of sub-devices support in simple probe Akari Tsuyukusa
2026-08-04  2:43   ` Chen-Yu Tsai
2026-08-03 14:16 ` [PATCH 12/32] clk: mediatek: Add pllfh support to common probe/remove helpers Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 13/32] clk: mediatek: mt2701: Switch " Akari Tsuyukusa
2026-08-04  2:45   ` Chen-Yu Tsai
2026-08-03 14:16 ` [PATCH 14/32] clk: mediatek: mt2712-apmixedsys: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 15/32] clk: mediatek: mt6735-apmixedsys: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 16/32] clk: mediatek: mt6779: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 17/32] clk: mediatek: mt6795: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 18/32] clk: mediatek: mt6797: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 19/32] clk: mediatek: mt7622: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 20/32] clk: mediatek: mt7981-apmixed: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 21/32] clk: mediatek: mt7986-apmixed: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 22/32] clk: mediatek: mt7988-apmixed: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 23/32] clk: mediatek: mt8135-apmixedsys: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 24/32] clk: mediatek: mt8167-apmixedsys: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 25/32] clk: mediatek: mt8173-infracfg: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 26/32] clk: mediatek: mt8183: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 27/32] clk: mediatek: mt8186-apmixedsys: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 28/32] clk: mediatek: mt8188-apmixedsys: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 29/32] clk: mediatek: mt8192: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 30/32] clk: mediatek: mt8195: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 31/32] clk: mediatek: mt8196: " Akari Tsuyukusa
2026-08-03 14:16 ` [PATCH 32/32] clk: mediatek: mt8516-apmixedsys: " Akari Tsuyukusa
2026-08-03 19:50 ` [PATCH 00/32] clk: mediatek: Migrate to common probe/remove helpers and fix memory leaks Jakub Kicinski
2026-08-03 20:28   ` Brian Masney
2026-08-04  1:40     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260803141659.559129-10-akkun11.open@gmail.com \
    --to=akkun11.open@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=bhelgaas@google.com \
    --cc=bmasney@redhat.com \
    --cc=dakr@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=kees@kernel.org \
    --cc=laura.nao@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=miles.chen@mediatek.com \
    --cc=mturquette@baylibre.com \
    --cc=netdev@vger.kernel.org \
    --cc=nfraprado@collabora.com \
    --cc=nicolas.frattaroli@collabora.com \
    --cc=o-takashi@sakamocchi.jp \
    --cc=richardcochran@gmail.com \
    --cc=sam.shih@mediatek.com \
    --cc=sboyd@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=vulab@iscas.ac.cn \
    --cc=wenst@chromium.org \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox