From: Jonathan Cameron <jic23@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org, linux@analog.com,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 0/2] iio: Make sure clk_init_data is fully initialized
Date: Sun, 23 Aug 2026 02:18:55 +0100 [thread overview]
Message-ID: <20260823021855.6f49bfcf@jic23-huawei> (raw)
In-Reply-To: <cover.1787240005.git.geert+renesas@glider.be>
On Fri, 21 Aug 2026 12:04:05 +0200
Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> Hi all,
>
> The clk_init_data structure contains several mutually-exclusive members
> for different methods to specify the possible parents of a clock,
> prompting drivers to initialize only the members they need. However,
> not initializing all members may cause subtle issues, which are only
> exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
> enabled.
>
> Hence this series aims to make sure all members are fully initialized,
> to avoid such bugs, and to prevent future breakage when converting
> drivers to a different method for specifying the parents.
>
> Part One[1] fixed all cases that I identified to be real bugs, in
> response to a crash I saw on BeagleBone Black.
>
> This series is the IIO subpart of Part Two, which fixes remaining cases
> that are currently harmless. These are still fragile, and may cause
> future breakage when converting drivers to a different method for
> specifying the parents.
>
> Thanks for your comments!
>
> [1] "[PATCH treewide 0/5] clk: Make sure clk_init_data is fully
> initialized (part 1)"
> https://lore.kernel.org/cover.1787165329.git.geert+renesas@glider.be
Applied to the testing branch of iio.git.
I made a trivial tweak from {} to { } to follow the style we are trying
to stick to for these in IIO.
Thanks,
Jonathan
>
> Geert Uytterhoeven (2):
> iio: adc: meson-saradc: Make sure clk_init_data is fully initialized
> iio: frequency: adf4350: Make sure clk_init_data is fully initialized
>
> drivers/iio/adc/meson_saradc.c | 2 +-
> drivers/iio/frequency/adf4350.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
prev parent reply other threads:[~2026-08-23 1:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 10:04 [PATCH 0/2] iio: Make sure clk_init_data is fully initialized Geert Uytterhoeven
2026-08-21 10:04 ` [PATCH 1/2] iio: adc: meson-saradc: " Geert Uytterhoeven
2026-08-21 11:03 ` Joshua Crofts
2026-08-21 10:04 ` [PATCH 2/2] iio: frequency: adf4350: " Geert Uytterhoeven
2026-08-23 1:18 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260823021855.6f49bfcf@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox