Re: [PATCH v2 2/2] clk: rk808: Select the clock function of CLK32KOUT2 on the RK818

[sashiko-bot@kernel.org]

> From: Martijn Braam <martijn@brixit.nl>
> 
> On the RK818 the CLK32KOUT2 pin is shared between the 32.768 kHz clock
> output and a recovery function, selected by bit 1 of RK808_CLK32OUT_REG.
> CLK32KOUT2_EN only takes effect on the clock function, so the output can
> be enabled and still be silent. The datasheet resets the register to
> zero, but that cannot be relied on: on the Pine64 PinePhone Pro it reads
> 0x03 once Linux is up, leaving the wifi and bluetooth without their
> 32.768 kHz reference.
> 
> Select the clock function when the output is prepared, so that it can
> also be given back, and report the output as prepared only when it is
> enabled and on the clock function. The bit is not defined on the other
> variants, so give the RK818 its own clk_ops. Boards that never take the
> clock are unaffected.
> 
> Based on an out-of-tree patch by Martijn Braam & Kamil Trzciński,
> carried by Ondrej Jirman.
> 
> Signed-off-by: Martijn Braam <martijn@brixit.nl>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-ppp_connectivity-v2-0-a4b0e11cd62c@gmail.com?part=2