Re: [PATCH v4 1/2] dt-bindings: Add GPIO-locked fixed clock

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]

On Thu, Aug 27, 2026 at 10:23:20AM +0200, Vyacheslav Yurkov wrote:
> On 10.08.2026 18:58, Conor Dooley wrote:
> > On Mon, Aug 10, 2026 at 11:54:03AM -0500, Rob Herring wrote:
> > > On Mon, Aug 10, 2026 at 11:40:00AM -0500, Rob Herring wrote:
> > > 
> > > I missed that this is N input clocks and 1 output clock. But that leads
> > > to other questions. You've implemented a clock mux then? I still don't
> > > understand for what h/w that makes sense. Which input clock is selected?
> > > The locked one?
> > 
> > Yeah, I thought this was n inputs and n outputs, with each gpio
> > signalling that an individual PLL had locked.
> 
> 
> It is n input clocks and 1 output clock. It is kind of a mux, but the CPU
> doesn't control the clocks or GPIO signals. The whole idea is that
> peripherals check the output clock, when it's locked that means _all_ the
> clocks are locked and GPIOs are in expected state. That's why the selection
> operation is not really implemented.
> 
> Actually the number of input clocks don't have to correspond to the number
> of the GPIOs, because the GPIO signals indicate the locked state of the
> clocks that are not accessible to the CPU.

I'm not entirely sure what you mean by this, but it is starting to sound
like you're only having one output because that's the minimum you need to do
to ensure that this driver has probed before the peripheral(s) using the
N input clocks. Requiring other input clocks to be stable before
declaring the input that's actually connected to the output stable
appears to be a shortcut/hack rather than an accurate description of the
hardware. If that's the case, I'd be much happier with this if this was
implemented as either a) N inputs with N gpios and N outputs, or b) 1 input,
M gpios (if multiple represent the stability of that input) and 1 output,
with N instances, one for each clock.
On the other hand, if this is genuinely a mux, then the binding should
reflect that, rather than only describe a subset of what you can do and
the driver should only check the actual parent out the output, rather
than the N-1 other inputs.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]