Re: [PATCH v3 16/19] phy: rockchip: inno-hdmi: Use the common Innosilicon PHY helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused macros `RK3328_SPREAD_SPECTRUM_MOD_DOWN` and `RK3328_SPREAD_SPECTRUM_MOD_DISABLE` were left behind despite the commit message claiming that unused pre-PLL macros were removed.
--

commit 103e72298ee1993440baf6c4457495f034d88185
Author: Michal Wilczynski <m.wilczynski@samsung.com>

phy: rockchip: inno-hdmi: Use the common Innosilicon PHY helpers

This commit refactors the RK3328 pre-PLL programming to use shared
Innosilicon PHY helpers. It removes local copies of register-level code,
macros, and table lookups. The RK3228 retains its own register code while
sharing the table lookup.

> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c b/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c
> index c3d257a0f4a65..17229d039132e 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c
> @@ -130,42 +131,17 @@
>  #define RK3328_INT_VSS_AGND_ESD_DET			BIT(1)
>  #define RK3328_INT_AGND_VSS_ESD_DET			BIT(0)
>  /* REG: 0xa0 */
> -#define RK3328_PCLK_VCO_DIV_5_MASK			BIT(1)
> -#define RK3328_PCLK_VCO_DIV_5(x)			UPDATE(x, 1, 1)
>  #define RK3328_PRE_PLL_POWER_DOWN			BIT(0)
>  /* REG: 0xa1 */
> -#define RK3328_PRE_PLL_PRE_DIV_MASK			GENMASK(5, 0)
> -#define RK3328_PRE_PLL_PRE_DIV(x)			UPDATE(x, 5, 0)
>  /* REG: 0xa2 */
>  /* unset means center spread */
>  #define RK3328_SPREAD_SPECTRUM_MOD_DOWN			BIT(7)
>  #define RK3328_SPREAD_SPECTRUM_MOD_DISABLE		BIT(6)

[Severity: Low]
Are these macros still needed? The commit message states that unused pre-PLL
macros are being removed, but these appear to have been left behind. Since
the shared helper uses its own definitions, are these now orphaned dead code?

> -#define RK3328_PRE_PLL_FRAC_DIV_DISABLE			UPDATE(3, 5, 4)
> -#define RK3328_PRE_PLL_FB_DIV_11_8_MASK			GENMASK(3, 0)
> -#define RK3328_PRE_PLL_FB_DIV_11_8(x)			UPDATE((x) >> 8, 3, 0)
>  /* REG: 0xa3 */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com?part=16