Re: [PATCH] clk: mediatek: mt6735-imgsys: Publish the OF module alias

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The patch adds MODULE_DEVICE_TABLE to the MT6735 imgsys driver to enable module autoloading, but fails to fix the identical missing module alias issue in the MT6735 mfgcfg driver introduced in the same commit.
--

commit 313e810d99540550a408b36b94980a65e251935e
Author: hpp.iscas <hppiscas@163.com>

clk: mediatek: mt6735-imgsys: Publish the OF module alias

This commit adds the MODULE_DEVICE_TABLE macro to the MT6735 imgsys
driver to publish the OF match table. This enables module autoloading
when the driver is built as a separately selectable tristate driver.

> diff --git a/drivers/clk/mediatek/clk-mt6735-imgsys.c b/drivers/clk/mediatek/clk-mt6735-imgsys.c
> index c564f8f724324..813241d526cf4 100644
> --- a/drivers/clk/mediatek/clk-mt6735-imgsys.c
> +++ b/drivers/clk/mediatek/clk-mt6735-imgsys.c
> @@ -41,6 +41,7 @@ static const struct of_device_id of_match_mt6735_imgsys[] = {
>  	{ .compatible = "mediatek,mt6735-imgsys", .data = &imgsys_clks },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, of_match_mt6735_imgsys);

[Severity: High]
This is a pre-existing issue, but since this patch fixes the missing module
autoloading introduced in commit 0bd9b1211f74, should it also fix the
identical issue in the MT6735 mfgcfg driver that was added in the same commit?

Without a similar MODULE_DEVICE_TABLE(of, of_match_mt6735_mfgcfg) declaration,
the clk-mt6735-mfgcfg driver will fail to automatically load when built as a
module, which can break dependent subsystems like the GPU and media blocks
that rely on these clocks:

drivers/clk/mediatek/clk-mt6735-mfgcfg.c:
static const struct of_device_id of_match_mt6735_mfgcfg[] = {
	{ .compatible = "mediatek,mt6735-mfgcfg", .data = &mfgcfg_clks },
	{ /* sentinel */ }
};
/* Missing MODULE_DEVICE_TABLE(of, of_match_mt6735_mfgcfg); */

static struct platform_driver clk_mt6735_mfgcfg = {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905133250.63975-1-hppiscas@163.com?part=1