Re: [PATCH v3] dt-bindings: clock: ti,da850-pll: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema fails to enforce that `ti,da850-pll0` requires exactly two clocks, making the second clock optional and violating the original text binding constraints.
--

commit 1e378ce145d7c772d10cbc597290a47125cd1157
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: clock: ti,da850-pll: Convert to DT schema
    
Convert TI da850-pll binding from legacy text to dt schema.
No functional change is introduced during conversion.

Link: https://lore.kernel.org/r/20260717-ti-pll-v1-1-f6f9ba8c9b5e@gmail.com

> diff --git a/Documentation/devicetree/bindings/clock/ti/davinci/ti,da850-pll.yaml b/Documentation/devicetree/bindings/clock/ti/davinci/ti,da850-pll.yaml
> new file mode 100644
> index 0000000000000..c6563290a702b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti/davinci/ti,da850-pll.yaml
> @@ -0,0 +1,164 @@
[ ... ]
> +  clocks:
> +    minItems: 1
> +    items:
> +      - description: Primary reference clock input
> +      - description: External clock source
> +
> +  clock-names:
> +    minItems: 1
> +    items:
> +      - const: clksrc
> +      - const: extclksrc

[Severity: Medium]
Does this schema unintentionally allow ti,da850-pll0 configurations with missing
external clocks to pass validation?

The global properties.clocks and properties.clock-names definitions both set
minItems: 1, which effectively makes the second clock (extclksrc) optional for
all compatible strings.

[ ... ]
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: ti,da850-pll1
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +        clock-names:
> +          maxItems: 1
> +        ti,clkmode-square-wave: false
> +        auxclk: false

[Severity: Medium]
While the allOf block correctly restricts ti,da850-pll1 to a single clock,
it appears to miss a matching conditional block (or else-clause) to enforce
the minItems: 2 requirement for ti,da850-pll0.

Since the original text binding mandated two clocks for ti,da850-pll0, should
there be a corresponding if-then block ensuring minItems: 2 for pll0?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906-ti-pll-v3-1-d1751f4648f0@gmail.com?part=1