Linux clock framework development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Taniya Das" <taniya.das@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: clock: qcom: document the Nord DPRX Clock Controller
Date: Mon, 07 Sep 2026 08:35:26 +0000	[thread overview]
Message-ID: <20260907083527.379551F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260907-nords_dprx-v1-2-d472af3f01b1@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The binding description incorrectly claims the module provides power domains.
--

commit baf2c48f03a1fa1acdae6f01871eb176b4af7ed4
Author: Taniya Das <taniya.das@oss.qualcomm.com>

dt-bindings: clock: qcom: document the Nord DPRX Clock Controller

This commit adds device tree bindings documentation for the Qualcomm Nord 
DisplayPort Receiver (DPRX) Clock Controller.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,nord-dprxcc.yaml b/Documentation/devicetree/bindings/clock/qcom,nord-dprxcc.yaml
> new file mode 100644
> index 0000000000000..fbaaad1f3db3f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,nord-dprxcc.yaml
[ ... ]
> +maintainers:
> +  - Taniya Das <taniya.das@oss.qualcomm.com>
> +
> +description: |
> +  Qualcomm dprx clock control module provides the clocks, resets and power
> +  domains on Nord.
> +

[Severity: Low]
Is it accurate that this module provides power domains?

The documentation text claims the hardware provides power domains, which
contradicts the binding schema below that only consumes a power domain via
power-domains: maxItems: 1 and does not define #power-domain-cells. Could
this be a copy-paste error from another binding?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-nords_dprx-v1-0-d472af3f01b1@oss.qualcomm.com?part=2

  reply	other threads:[~2026-09-07  8:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  8:26 [PATCH 0/3] clk: qcom: Add Nord DPRX clock controller support Taniya Das
2026-09-07  8:26 ` [PATCH 1/3] clk: qcom: clk-alpha-pll: support a 28-bit ALPHA_VAL width Taniya Das
2026-09-07  8:38   ` sashiko-bot
2026-09-07 10:30   ` Abel Vesa
2026-09-09  8:41   ` Shawn Guo
2026-09-10  8:10     ` Taniya Das
2026-09-07  8:26 ` [PATCH 2/3] dt-bindings: clock: qcom: document the Nord DPRX Clock Controller Taniya Das
2026-09-07  8:35   ` sashiko-bot [this message]
2026-09-07 10:38   ` Abel Vesa
2026-09-09  8:31   ` Shawn Guo
2026-09-10  8:55     ` Taniya Das
2026-09-07  8:26 ` [PATCH 3/3] clk: qcom: dprxcc: Add Nord DPRX clock controller support Taniya Das
2026-09-07  8:55   ` sashiko-bot
2026-09-07 10:43   ` Abel Vesa
2026-09-09  9:06   ` Shawn Guo
2026-09-10  9:08     ` Taniya Das
2026-09-09  8:34 ` [PATCH 0/3] clk: qcom: " Shawn Guo
2026-09-10  8:14   ` Taniya Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907083527.379551F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=taniya.das@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox