From: Chukun Pan <amadeus@jmu.edu.cn>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Jerome Brunet <jbrunet+clk@baylibre.com>,
Brian Masney <bmasney+clk@redhat.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, Chukun Pan <amadeus@jmu.edu.cn>
Subject: [PATCH 1/1] clk: qcom: ipq8074: set BRANCH_HALT_VOTED flag for usb master clocks
Date: Thu, 10 Sep 2026 18:00:00 +0800 [thread overview]
Message-ID: <20260910100000.2627799-1-amadeus@jmu.edu.cn> (raw)
Currently, on some boards with older versions of U-Boot, attempting
to disable usb master clocks results in a "stuck at on" warning:
[ 3.005088] gcc_usb1_master_clk status stuck at 'on'
[ 3.187119] gcc_usb0_master_clk status stuck at 'on'
The USB master clocks of IPQ5332 and IPQ5424 have the BRANCH_HALT_VOTED
flag set, so let's do the same to fix the issue.
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
These boards run a vendor-specific version of U-Boot, and upgrading to
a newer version could brick the device. Therefore, I think this should
be fixed within the Linux kernel.
---
drivers/clk/qcom/gcc-ipq8074.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
index 1329ea28d703..10bd2f80010c 100644
--- a/drivers/clk/qcom/gcc-ipq8074.c
+++ b/drivers/clk/qcom/gcc-ipq8074.c
@@ -2612,6 +2612,7 @@ static struct clk_branch gcc_sys_noc_usb0_axi_clk = {
static struct clk_branch gcc_usb0_master_clk = {
.halt_reg = 0x3e000,
+ .halt_check = BRANCH_HALT_VOTED,
.clkr = {
.enable_reg = 0x3e000,
.enable_mask = BIT(0),
@@ -2725,6 +2726,7 @@ static struct clk_branch gcc_sys_noc_usb1_axi_clk = {
static struct clk_branch gcc_usb1_master_clk = {
.halt_reg = 0x3f000,
+ .halt_check = BRANCH_HALT_VOTED,
.clkr = {
.enable_reg = 0x3f000,
.enable_mask = BIT(0),
--
2.34.1
next reply other threads:[~2026-09-10 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 10:00 Chukun Pan [this message]
2026-09-10 10:06 ` [PATCH 1/1] clk: qcom: ipq8074: set BRANCH_HALT_VOTED flag for usb master clocks Taniya Das
2026-09-11 6:40 ` Chukun Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910100000.2627799-1-amadeus@jmu.edu.cn \
--to=amadeus@jmu.edu.cn \
--cc=andersson@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=jbrunet+clk@baylibre.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox