From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E64F3BBFB0; Tue, 15 Sep 2026 15:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789486967; cv=none; b=qErlWHdI2C6xAD1mCAPxQpx4OFUqcvPcL0oRDTGUjKr7AZn8+on6OI/JF1dxWiUq6SrsacLvzbjqALsV4q33sltgbGtqte1tEVH0RQEnr5l/FdLUdZIQRiZFRwidhk0QqqYEjDySxTY6ALtKzWj76F4S4eJbUAZC4Sa2oDsca1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789486967; c=relaxed/simple; bh=AX4ZPiwoECjWJdEGXj/MDeda6bu8zZxZKkmx2AN2TIw=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=EuFdTs1IRMFsD+4YPV8C+siwstHxxEG/hjH5MrjS9EnA/gowaTckeCfYwKUcLgDFzmAjy3z1oYYq/jZcS+b9AFQYCL876KsA2oLXDRTqzcQEYypX6jVtuFQDEE2t6adlHT5VXc94hNpMiB/8FlTVHblcR3OWIuxUG6w+47JF/y0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HzElr28T; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HzElr28T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB10A1F000FF; Tue, 15 Sep 2026 15:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789486965; bh=AX4ZPiwoECjWJdEGXj/MDeda6bu8zZxZKkmx2AN2TIw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=HzElr28TA2A6t61nW10Ne++osJPTsbGCzMP8PxZf9TkC22tkHny0PUmSm0mrtYt5E qHrRn7WdlXIwcaCevu0vhmJGc+5VykOc8MyhsU3XyFKth17SAel0jzGLEJj6ZG8exv /dNFWFRK3elx2rM9FqC73f5K9JBOG4DNgGL29T/IPLaTxkzC+IL5JwnCI0nkOuPO4e zAtvJN5aXHAGjeJjLmxFi0NOmpAXGv7p96FCR1EezQID5mW02/o/czyqNEWziabbOU qyanKfDkT2ppY+LZY0QS/AVpCJgusZrkbj+QMH2qqle12F2WMC1p1HI5yr1bJ+fbRS JWwThRNRNl+Fw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 15/20] drm/bridge: starfive: Add JH7110 HDMI controller driver Reply-To: sashiko-reviews@lists.linux.dev To: "Michal Wilczynski" Cc: olteanv@gmail.com, robh@kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, lee@kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org, mfd@lists.linux.dev, linux-phy@lists.infradead.org, vkoul@kernel.org In-Reply-To: <20260915-jh7110-clean-send-v4-15-f0e4fd6f2cc8@samsung.com> References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-15-f0e4fd6f2cc8@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 15 Sep 2026 15:42:43 +0000 Message-Id: <20260915154243.EB10A1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > Add the HDMI controller (bridge) driver for the StarFive JH7110. >=20 > This driver binds to the starfive,jh7110-inno-hdmi-controller node. It > gets its register access, module and bus clocks from voutcrg, and > consumes the pixel clock and the PHY from its hdmi_phy sibling. >=20 > The driver calls the generic inno_hdmi_probe function, which picks up > the regmap shared with the PHY from the parent device and registers a > DRM bridge. The .enable hook is responsible for setting the PHY's pixel > clock rate via clk_set_rate() and powering on the PHY via > phy_power_on(). >=20 > The DC8200 has two panels, each exposing a DP and a DPI interface, and a > mux in the video output system controller picks which of them drives the > HDMI transmitter. It comes out of reset on panel 0 / DPI, which happens > [ ... ] > devm_drm_bridge_add(). Releasing them in .remove runs before devres > unwinds and would leave the bridge registered with its clocks already > gated. >=20 > Signed-off-by: Michal Wilczynski Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260915-jh7110-cle= an-send-v4-0-f0e4fd6f2cc8@samsung.com?part=3D15