From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DDE436E49B; Tue, 15 Sep 2026 15:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789487096; cv=none; b=j6O0LywZ0HV0fEeC0ho7dtssg1EY7yoDP0qFYbpJQqM8VOOXVfZWjNH6wUhtu11yeq9YXybTMYXPDjKNulxUVHnzBov9/uqusakifkzkhQLaJcGG9buHsbQC+DAkKWMxm0eMj5krssUos8R42rAie6CXcpY83XGESz4JEAhh+VM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789487096; c=relaxed/simple; bh=GvuoUipLDuYtu3iX26Vf6qEhYNBdGvGU3cMz59AmzU4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ed9eGrWjErZy+zo8YqO4EPX6IqPoJTLKeVusJzMhky7Su0LIN1IwLJMPGZUzzfKpuE9IESj+Qna3QvInnI8oz21AICIA4D35U16X8cHBGNdhoddpqUE8L0XGQb1OvQmybdiEfGQ1qnTjSVQiOQ6xZIqbiZSZqXJFxrXMlO2ygTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RxB4aWbE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RxB4aWbE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E758B1F00893; Tue, 15 Sep 2026 15:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789487093; bh=QEBXUCGA3t5aIDeoUC+JSqnO28lAavBO8vWCn83qxws=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=RxB4aWbEruBsnXKfNLqbKvd6g9+7Poo7Pnm3+LUo9+LVGTrgtFDCaKPkmxzdVW7ne Dsy6w+dNLDG0aYz1QO9z3U1dx7JLTtyXyCGuvx3fmueF+pFM3KZQUD4wzaRatbfs21 ZdeQ3lYggrSs0YE+aTjFnpL0A0xEmiibJQyRGcrF+78htalUhqvCp4exAGrMf1Asqn w120kqakOTpg+sYPWjbPp9hOl1XdK8ddze5sdqzTfQKTG6OQuAw5NHCfJhMPKkDCqK /JbNrXTSXBSzwyjkNELDcSDZOs9kgUfRX7+wD5PGvd02D40E7VnjzIH9/RFhM5aLiE Zn3mg6Pnw9CVQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 12/20] soc: starfive: Add jh7110-hdmi-subsystem driver Reply-To: sashiko-reviews@lists.linux.dev To: "Michal Wilczynski" Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org, mfd@lists.linux.dev, conor+dt@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org, olteanv@gmail.com, dri-devel@lists.freedesktop.org, vkoul@kernel.org, lee@kernel.org In-Reply-To: <20260915-jh7110-clean-send-v4-12-f0e4fd6f2cc8@samsung.com> References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-12-f0e4fd6f2cc8@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 15 Sep 2026 15:44:52 +0000 Message-Id: <20260915154452.E758B1F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] soc: starfive: unsafe 8-bit regmap MMIO accesses for 32-bit HDMI IP -- commit 0e53205c6430272fda82936e32d4dd11694a8847 Author: Michal Wilczynski soc: starfive: Add jh7110-hdmi-subsystem driver This commit adds the parent driver for the monolithic JH7110 HDMI IP block. It binds to the starfive,jh7110-hdmi-subsystem node, maps the shared register block, creates a regmap, and populates child devices. > diff --git a/drivers/soc/starfive/jh7110-hdmi-subsystem.c b/drivers/soc/s= tarfive/jh7110-hdmi-subsystem.c > new file mode 100644 > index 0000000000000..e64a222630459 > --- /dev/null > +++ b/drivers/soc/starfive/jh7110-hdmi-subsystem.c [ ... ] > +#include > +#include > +#include > +#include > +#include > + > +static const struct regmap_config starfive_hdmi_regmap_config =3D { > + .reg_bits =3D 32, > + .val_bits =3D 8, [Severity: High] Does configuring .val_bits =3D 8 cause the regmap-mmio backend to select 8-= bit memory accessors (writeb()/readb())?=20 On many 32-bit APB/AHB bus fabrics, issuing byte-wide memory transactions to 32-bit IP registers triggers synchronous external aborts (bus errors leading to a kernel panic) or results in partial register corruption. This can be triggered autonomously when the child drivers probe and attempt to read or write HDMI registers via the shared regmap. Since the fallback MMIO implementation in the inno-hdmi child driver uses readl_relaxed() and writel_relaxed(), it appears the IP natively expects 32-bit physical accesses. Should .val_bits =3D 32 be used here to guarantee regmap-mmio maps to safe 32-bit physical accessors? > + .max_register =3D 0x3fff, > +}; > + > +static int starfive_hdmi_subsys_probe(struct platform_device *pdev) [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260915-jh7110-cle= an-send-v4-0-f0e4fd6f2cc8@samsung.com?part=3D12