From: sashiko-bot@kernel.org
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
Cc: linux-phy@lists.infradead.org, linux-clk@vger.kernel.org,
media-ci@linuxtv.org, vkoul@kernel.org,
neil.armstrong@linaro.org, olteanv@gmail.com,
devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v20 4/6] phy: core: Add missing kerneldoc colon in two locations
Date: Fri, 18 Sep 2026 14:08:01 +0000 [thread overview]
Message-ID: <20260918140801.A5C1D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260918-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v20-4-dc244e124e71@linaro.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] phy: commit message says two locations but modifies three
--
commit 5a2b69cff2bb3f7d12d886564973ff075c24a850
Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
phy: core: Add missing kerneldoc colon in two locations
This patch corrects missing colons after "Return" in the kernel doc for the
phy core.
> phy: core: Add missing kerneldoc colon in two locations
[Severity: Low]
This isn't a bug, but the commit subject states that "two locations" are
being updated, while the patch actually modifies the kerneldoc for three
distinct functions: _of_phy_get(), of_phy_get(), and phy_get().
Should the commit message be updated to accurately reflect the three
locations modified?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v20-0-dc244e124e71@linaro.org?part=4
next prev parent reply other threads:[~2026-09-18 14:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 13:56 [PATCH v20 0/6] Add phy_get_by_of_node and devm helper Bryan O'Donoghue
2026-09-18 13:56 ` [PATCH v20 1/6] phy: core: Fix race-condition between _of_phy_get() and try_module_get() Bryan O'Donoghue
2026-09-18 13:56 ` [PATCH v20 2/6] phy: core: Add phy_get_by_of_node() Bryan O'Donoghue
2026-09-18 14:10 ` Neil Armstrong
2026-09-18 14:27 ` Bryan O'Donoghue
2026-09-18 15:35 ` johannes.goede
2026-09-22 12:19 ` Neil Armstrong
2026-09-22 12:14 ` Neil Armstrong
2026-09-22 12:36 ` Manivannan Sadhasivam
2026-09-18 13:56 ` [PATCH v20 3/6] phy: core: Add devm_phy_get_by_of_node() Bryan O'Donoghue
2026-09-18 14:10 ` Neil Armstrong
2026-09-18 13:56 ` [PATCH v20 4/6] phy: core: Add missing kerneldoc colon in two locations Bryan O'Donoghue
2026-09-18 14:08 ` sashiko-bot [this message]
2026-09-18 14:11 ` Neil Armstrong
2026-09-22 12:37 ` Manivannan Sadhasivam
2026-09-18 13:56 ` [PATCH v20 5/6] media: qcom: camss: Add support for PHY API devices Bryan O'Donoghue
2026-09-18 14:19 ` sashiko-bot
2026-09-18 14:48 ` Loic Poulain
2026-09-22 9:15 ` Konrad Dybcio
2026-09-22 9:32 ` Bryan O'Donoghue
2026-09-25 16:40 ` Liviu Nicoara
2026-09-27 8:40 ` johannes.goede
2026-09-27 15:32 ` Liviu Nicoara
2026-09-18 13:56 ` [PATCH v20 6/6] media: qcom: camss: Use data-lanes starting at 1 for new CSIPHY mode Bryan O'Donoghue
2026-09-25 16:41 ` Liviu Nicoara
2026-09-23 12:35 ` (subset) [PATCH v20 0/6] Add phy_get_by_of_node and devm helper Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918140801.A5C1D1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=media-ci@linuxtv.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox