Re: [PATCH v9 1/2] dt-bindings: clock: add TI CDCE6214 binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: invalid additionalProperties with $ref rejects inherited properties
--

commit 666b5411b0002edaa523fde47133ad3f08a2f5b5
Author: Sascha Hauer <s.hauer@pengutronix.de>

dt-bindings: clock: add TI CDCE6214 binding

This commit adds a device tree binding for the TI CDCE6214 clock generator.
It defines properties for clocks, pins, and specific IO configurations.

> diff --git a/Documentation/devicetree/bindings/clock/ti,cdce6214.yaml b/Documentation/devicetree/bindings/clock/ti,cdce6214.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti,cdce6214.yaml

[ ... ]

> +patternProperties:
> +  '-pins$':
> +    type: object
> +    additionalProperties: false
> +
> +    patternProperties:
> +      '^conf':
> +        type: object
> +        additionalProperties: false
> +        $ref: /schemas/pinctrl/pincfg-node.yaml#

[Severity: Medium]
Will this additionalProperties restriction reject the properties inherited from
the $ref schema?

In JSON Schema semantics, additionalProperties only considers the properties
explicitly enumerated in the local properties block. It does not evaluate
properties brought in by a $ref. 

Because of this, any attempt to use standard pinctrl properties in a device tree
will trigger a validation failure, as the local schema forcefully rejects them.

Should this use unevaluatedProperties: false instead to allow the standard
properties from pincfg-node.yaml to be evaluated properly?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-clk-cdce6214-v9-0-f2ea74fd38a2@pengutronix.de?part=1