Re: [PATCH v3 12/19] dt-bindings: clock: qcom,rpmcc: Add MSM8952 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: clock: missing msm8952 in constraints conditional block
--

commit 08e2cd81c0f804c9a9db2e8d8d60babe26ca3d55
Author: Muzaffer Kadir <muzafferkadir@mainlining.org>

dt-bindings: clock: qcom,rpmcc: Add MSM8952 compatible

Document the rpmcc found on MSM8952.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> --- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> @@ -56,6 +56,11 @@ properties:
>                - qcom,rpmcc-shikra
>            - const: qcom,rpmcc-qcm2290
>            - const: qcom,rpmcc
> +      - items:
> +          - enum:
> +              - qcom,rpmcc-msm8952
> +          - const: qcom,rpmcc-msm8976
> +          - const: qcom,rpmcc

[Severity: Medium]
Does qcom,rpmcc-msm8952 also need to be added to the allOf conditional
block that enforces the xo clock constraints?

Because qcom,rpmcc-msm8952 falls back to qcom,rpmcc-msm8976, it shares the
same xo clock requirement. Currently, qcom,rpmcc-msm8976 is listed in the
conditional block:

Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml:
  - if:
      properties:
        compatible:
          contains:
            enum:
              ...
              - qcom,rpmcc-msm8974
              - qcom,rpmcc-msm8976
              ...
    then:
      properties:
        clocks:
          items:
            - description: xo clock

Should qcom,rpmcc-msm8952 be added to this enum list? When running
dt_binding_check on a device tree containing the qcom,rpmcc-msm8952
compatible string, the clock constraints will not be enforced.

>  
>    '#clock-cells':
>      const: 1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-msm8952-initial-support-v3-0-b96fd3fe298b@mainlining.org?part=12