Re: [PATCH 1/3] dt-bindings: clock: qcom,sm8450-videocc: Fix clock inputs for Glymur

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: hallucinated qcom,nord-videocc omitted from top-level enum
--

commit 0ca2f034154349c48cdd7a693b1d8282d6886964
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

dt-bindings: clock: qcom,sm8450-videocc: Fix clock inputs for Glymur

The commit updates the clock inputs for the Glymur, Nord, and SM8750
variants in the bindings from exactly two items to up to three items. This
change allows device trees to supply the sleep clock input required by
these drivers, resolving an issue where it would register as an orphan
clock.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> index 910c6d5672b86..dc01c37dcd0e3 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml

[ ... ]

> @@ -77,6 +76,27 @@ allOf:
>      then:
>        required:
>          - required-opps
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,glymur-videocc
> +              - qcom,nord-videocc

[Severity: Medium]
Is qcom,nord-videocc missing from the top-level properties/compatible enum
list? When a compatible string is introduced in the allOf/if conditional
logic but omitted from the top-level enum list (under unevaluatedProperties:
false), any device tree node using it will unconditionally fail validation.

Additionally, the commit message mentions that videocc-glymur.c handles
qcom,nord-videocc, but this identifier does not appear to exist anywhere in
the kernel tree. Could this compatible string be an LLM hallucination?

> +              - qcom,sm8750-videocc
> +    then:
> +      properties:
> +        clocks:
> +          items:
> +            - description: Board XO source
> +            - description: Board always-on XO source
> +            - description: Sleep clock source
> +    else:
> +      properties:
> +        clocks:
> +          items:
> +            - description: Board XO source
> +            - description: Video AHB clock from GCC
>  
>  unevaluatedProperties: false
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924161152.1162301-1-shengchao.guo@oss.qualcomm.com?part=1