Re: [PATCH 11/20] pinctrl: berlin: enable module build support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] pinctrl: berlin: missing Kconfig/Makefile changes for module build
--

commit 90017c53ecb9e3f7c921f299ee20085471283f78
Author: Jisheng Zhang <jszhang@kernel.org>

pinctrl: berlin: enable module build support
    
This commit updates the berlin pinctrl library to use devres allocation APIs,
exports necessary symbols, and adds module metadata. This is intended to allow
building the drivers as loadable modules for vendor_dlkm deployments.

> For Android GKI + vendor_dlkm deployments, where vendor-specific
> drivers must be kept separate from the GKI vmlinux and loaded as
> modules from the vendor partition, we need to enable module build
> support for berlin pinctrl drivers.

[Severity: High]
Are Kconfig and Makefile updates also needed to fully enable module support?

The commit message states the goal is to enable module builds, but Kconfig
and Makefile changes appear to be missing from the patch. 

In drivers/pinctrl/berlin/Kconfig, PINCTRL_BERLIN is currently restricted
to bool:

config PINCTRL_BERLIN
	bool

In drivers/pinctrl/berlin/Makefile, berlin.o is unconditionally built-in:

obj-y += berlin.o

Without changing these to use a tristate and obj-$(CONFIG_PINCTRL_BERLIN),
the object is compiled into a built-in archive during a module build. It is
never linked into the loadable module, which causes undefined references to
berlin_pinctrl_probe during driver loading.

Additionally, does builtin_platform_driver() in the SoC drivers prevent them
from being built as modules?

For example, in drivers/pinctrl/berlin/berlin-bg2.c:

builtin_platform_driver(berlin2_pinctrl_driver);

Would this need to be updated to module_platform_driver() to allow existing
SoC drivers to be built as loadable modules alongside the core library?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929061417.20733-1-jszhang@kernel.org?part=11