Re: [PATCH v15 04/11] clk: realtek: Introduce common probe()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] clk: realtek: aux_name in struct rtk_clk_desc is missing const qualifier
--

commit 70362e309c085cb7899e077d069e8a4a7e5719cc
Author: Cheng-Yu Lee <cylee12@realtek.com>

clk: realtek: Introduce common probe()

Add rtk_clk_probe() to set up the shared regmap, register clock hardware,
and add the clock provider. Additionally, if the "#reset-cells" property is
present, it creates and registers an auxiliary device.

> diff --git a/drivers/clk/realtek/clk-rtk-common.h b/drivers/clk/realtek/clk-rtk-common.h
> new file mode 100644
> index 0000000000000..de3f23120b539
> --- /dev/null
> +++ b/drivers/clk/realtek/clk-rtk-common.h
> @@ -0,0 +1,37 @@

[ ... ]

> +struct rtk_clk_desc {
> +	struct clk_hw_onecell_data *clk_data;
> +	struct rtk_clk_regmap **clks;
> +	size_t num_clks;
> +	char *aux_name;

[Severity: Low]
Would it be better for aux_name to be a const char pointer here?

Since this struct member is typically assigned string literals by caller
drivers, dropping the const qualifier exposes read-only memory to accidental
modification and could cause compiler warnings if compiled with
-Wwrite-strings.

> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002074331.3066919-1-eleanor.lin@realtek.com?part=4