Re: [PATCH] dt-bindings: clock: Convert HiSilicon clocks to DT schema

[Rob Herring <robh@kernel.org>]

On Fri, Oct 02, 2026 at 09:13:50AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] dt-bindings: missing if-then constraints for stub clock properties
> - [Low] dt-bindings: YAML conversion dropped all DT examples
> --
> 
> commit 9d6ccc9389906ef23ff428ed84de04603566232a
> Author: Rob Herring (Arm) <robh@kernel.org>
> Date:   Thu Oct 1 21:20:48 2026 +0000
> 
>     dt-bindings: clock: Convert HiSilicon clocks to DT schema
> 
> This commit converts the HiSilicon Hi6220, Hi3660, and Hi3670 clock
> bindings from legacy text format to YAML DT schema format. It also
> splits out the stub clock binding into its own standalone document.
> 
> > diff --git a/Documentation/devicetree/bindings/clock/hisilicon,clocks.yaml b/Documentation/devicetree/bindings/clock/hisilicon,clocks.yaml
> > new file mode 100644
> > index 0000000000000..345c6d0e7a134
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/hisilicon,clocks.yaml
> 
> [ ... ]
> 
> > +required:
> > +  - compatible
> > +  - reg
> > +  - '#clock-cells'
> > +
> > +additionalProperties: false
> 
> [Severity: Low]
> Were the device tree examples intentionally omitted during the conversion?

Yes. The binding is trivial.

> The original hi3660-clock.txt and hi3670-clock.txt bindings included example
> nodes, but they have been dropped entirely here. Running make dt_binding_check
> will only validate the schema syntax itself, but without an examples block, it
> will not validate any real configurations. This circumvents the primary
> self-testing mechanism of the schema conversion.
> 
> > diff --git a/Documentation/devicetree/bindings/clock/hisilicon,hi6220-stub-clk.yaml b/Documentation/devicetree/bindings/clock/hisilicon,hi6220-stub-clk.yaml
> > new file mode 100644
> > index 0000000000000..4dd6a01bfd9db
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/hisilicon,hi6220-stub-clk.yaml
> 
> [ ... ]
> 
> > +required:
> > +  - compatible
> > +  - '#clock-cells'
> > +  - mboxes
> 
> [Severity: Medium]
> Should there be conditional (if-then) constraints here to enforce
> hardware-specific requirements?

No. These are old, hardly maintained devices with no new platforms 
being added. It just doesn't matter here.

Rob