From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C863C51FCB6 for ; Tue, 13 Oct 2026 15:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904685; cv=none; b=DAQiqx65Pero+pspkTocLn/4cFWMXb+CLAK1VCfHXLPWVBsYX3Y2FptBMso5U47fK0w8UAHp3gfGEDzQPq9SGCqQmEnITL2F9f+Wh/NVUbsfIqIyBZTeIA1ZUzR1xqJwP68sAp093NvHsHFsNopaftVVMz7e+ZU3GHtTgGV5eIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904685; c=relaxed/simple; bh=vx2/wzvjNukbpfMa2SjGZEHeNaHuzGGqIzZhcaRZMVU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B+sVAtNSmK8QxEvbq9Buvk6axVk0QihHc7PUKPjmkxDp6Y31c029wg8NXSNhQDZFyXOatRMqY8bP6fwfpmk7EEM1nGMN4ZsIF2ald47gNY/GMPaOMyuJqKyGCvvBxAKqhP8jVVdLzLSPo1QeuyIW9HNnzcwbw9X3yAFaaKTge5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PKLjbv7Q; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PKLjbv7Q" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-88bd2b44f3aso1453388b3a.0 for ; Tue, 13 Oct 2026 08:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791904683; x=1792509483; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5fVc8UeH+5da/hVDNrPa5heU1KsL+eYQi/ZKHAgy494=; b=PKLjbv7Q3ufmDycslshJneS5AUJ9SpChnrlgWb8jPOZGWEL/WeFsqbHwklLwJn7Iv1 iOOWkyrChXiaBbAdRHlT9ntJ1rmJcaKIzUAeLUft/9g7Xu/bJEroiZDie5u4LiZJJ99X OeK2e5HPo5a8y2l3lSLV0GKmxJzBBlzVtSqOwnWQIiSZksEvw5T3FZU6bdVq6GZK3mW+ oANYYvFLfvYD6evvbE+yaOM6oeLDYMRbeza2RRokraUYuHHgNo6+OIwix0qofa+p0nIf /WIMrZDOGXqNLBisFn5j5Uaog/oDLDM8Ek3e9oI8vd4XIkkPkBxme6rn5x66HRlSWo7X vkwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791904683; x=1792509483; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5fVc8UeH+5da/hVDNrPa5heU1KsL+eYQi/ZKHAgy494=; b=dzPW72J5IIIDsJR+6dvDdgFLjG5H4IHvxk3mDYA3Kt2xS2Y/vx5CTyv7GzsdVDBDd2 aeORrUpcJczrzlmx4l9Rghs47Ruf9rx1T/iNbEtjoBkEnL0+NdWQocQOx5YvOiqrW6pw TU9CRg4oaNxULe1gbzYNUUgAfH1QVn+et6iwwuvaG8vg2x13/BAHcQYkIzDXb/DdJUVw 6jClXa2sHMzhmNWTiyzmeAqo8PwFIxFhpyDCjV91Alj84iJfMO9RUzkM0Da0PbEEIDyM dzmSQy0vvvrFKceCX+1M3PGuRup7mHOTZAtTh9xN1n3yfLylvcGhCcaHY0/sVhLo9071 oY1A== X-Forwarded-Encrypted: i=1; AKwUvBwilMn/BCpr2eQ2XxRjm4Soyl3gTPeuPrFeKHW0RqBPsHQxGFlq4B5JT9EzxBplSQldX63jxNhbmOs=@vger.kernel.org X-Gm-Message-State: AFq9FYJuoqQuJC1wOXKr1ORWIkEfiTooQ6TcQtC7S+KMqKvZd7rNFWnZ 8yA/INXHsxGotakca6t1us7E4f+Xf2jq+CdahWWmlS+k71VdOc2TlJ6p X-Gm-Gg: AYBFou1VxctjpTt1lTNtH0CsDrV0+zV95uxM3tMu2Xu+F+w0z0pCp3l2MWOdW/ZuGDp x1T2ziUWq041UwQCJdaC+/o2dXVCVe+AEt/1SSKpusivE8TTfp4RFWy7lFgupu2FZBFnLmsP0G0 r1xf0m4a+HLrl4eohSv6XwO/oULzKyT6z+eDs97pBMQKkXNzuhcKMZYroWEjeo5oUWOVUvYOc82 134zUnsYr0Nynthz2pHOjvrvcphNVTYN6UCwDgXILwVgSVPHa4Amn/3Z2vf7fYAlgghXbCcKwBU PqBcXf9mnSCk7uCByZ27ERmzOE3zGZ4dyBugD7N6eQe8B9wWliAj9DTKjq/buGTHQOJKbxeOQ1v Z0dEzZN1St7og0V7/4UOBrOPsTBQIfUWrpNgZI5WmZKRuBbUsZ7k8y3/SIg95iAc4zkYzauBS9w KysnOLCXWgZSNBhmWWKgBLHYBYNrokBepJcAqqIDRcfvOK8xampHp0/T+3a5UCvPTLxZUUE1wS1 61yFfpi3PyhkrMHKjmqXOLjxt7UQ3NyXefkcvs= X-Received: by 2002:a05:6a20:a10c:b0:3de:79fe:13f with SMTP id adf61e73a8af0-3e16bf27deemr11023823637.38.1791904682967; Tue, 13 Oct 2026 08:18:02 -0700 (PDT) Received: from buffalo-ssd.taila54753.ts.net ([240b:253:4760:f400:1ebf:ceff:fe7f:5e0b]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd3da04596dsm5759888a12.29.2026.10.13.08.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 08:18:02 -0700 (PDT) From: Akari Tsuyukusa To: Brian Masney , Jerome Brunet , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Chen-Yu Tsai , Bartosz Golaszewski , Kees Cook , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Danilo Krummrich , Nicolas Frattaroli , Bjorn Helgaas , Takashi Sakamoto , Haotian Zhang , Miles Chen , Sam Shih , Daniel Golle , Chun-Jie Chen , Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), Akari Tsuyukusa , stable@vger.kernel.org, Brian Masney Subject: [PATCH v2 01/35] clk: mediatek: mt2712: Fix memory leak on module removal Date: Wed, 14 Oct 2026 00:17:00 +0900 Message-ID: <20261013151734.3177690-2-akkun11.open@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261013151734.3177690-1-akkun11.open@gmail.com> References: <20261013151734.3177690-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clk_mt2712_apmixed_probe() in clk-mt2712-apmixedsys.c does not call platform_set_drvdata(), but clk_mt2712_apmixed_remove() callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: c6368ce86435 ("clk: mediatek: mt2712-apmixedsys: Add .remove() callback for module build") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa Reviewed-by: Brian Masney --- Changes in v2: - Capitalize the first letter of the commit message: "fix" -> "Fix" --- drivers/clk/mediatek/clk-mt2712-apmixedsys.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt2712-apmixedsys.c b/drivers/clk/mediatek/clk-mt2712-apmixedsys.c index 54b18e9f83f8..087cf574bcdc 100644 --- a/drivers/clk/mediatek/clk-mt2712-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt2712-apmixedsys.c @@ -129,6 +129,8 @@ static int clk_mt2712_apmixed_probe(struct platform_device *pdev) goto unregister_plls; } + platform_set_drvdata(pdev, clk_data); + return 0; unregister_plls: -- 2.56.0