From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jiebing Chen <jiebing.chen@amlogic.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com
Subject: Re: [PATCH v7 1/5] dt-bindings: clock: meson: Add audio power domain for S4 soc
Date: Wed, 28 Oct 2026 15:48:44 +0100 [thread overview]
Message-ID: <20261028-sparkling-objective-cricket-a428bd@quoll> (raw)
In-Reply-To: <20261021-audio_drvier-v7-1-2b9aeae9cb8a@amlogic.com>
On Wed, Oct 21, 2026 at 03:08:28PM +0800, Jiebing Chen wrote:
> The audio power domain has been found on S4 device.
> It must be enabled prior to audio operations.
>
> Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
> ---
> .../bindings/clock/amlogic,axg-audio-clkc.yaml | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
> index fd7982dd4cea..69f5fef5f14a 100644
> --- a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
> +++ b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
> @@ -20,6 +20,7 @@ properties:
> enum:
> - amlogic,axg-audio-clkc
> - amlogic,g12a-audio-clkc
> + - amlogic,s4-audio-clkc
> - amlogic,sm1-audio-clkc
>
> '#clock-cells':
> @@ -100,6 +101,8 @@ properties:
> resets:
> description: internal reset line
>
> + power-domains:
> + maxItems: 1
Missing blank line.
> required:
> - compatible
> - '#clock-cells'
> @@ -115,6 +118,7 @@ allOf:
> contains:
> enum:
> - amlogic,g12a-audio-clkc
> + - amlogic,s4-audio-clkc
> - amlogic,sm1-audio-clkc
> then:
> required:
> @@ -122,7 +126,18 @@ allOf:
> else:
> properties:
> '#reset-cells': false
> -
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - amlogic,s4-audio-clkc
> + then:
> + required:
> + - power-domains
> + else:
> + properties:
> + power-domains: false
And here as well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-28 14:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 7:08 [PATCH v7 0/5] Add support for S4 audio Jiebing Chen via B4 Relay
2026-10-21 7:08 ` [PATCH v7 1/5] dt-bindings: clock: meson: Add audio power domain for S4 soc Jiebing Chen via B4 Relay
2026-10-28 14:48 ` Krzysztof Kozlowski [this message]
2026-10-29 2:56 ` Jiebing Chen
2026-10-21 7:08 ` [PATCH v7 2/5] dt-bindings: Asoc: axg-audio: Add S4 audio tocodec Jiebing Chen via B4 Relay
2026-10-21 7:08 ` [PATCH v7 3/5] ASoC: meson: g12a-toacodec: Add S4 tocodec driver Jiebing Chen via B4 Relay
2026-10-21 7:28 ` sashiko-bot
2026-10-21 15:08 ` Jerome Brunet
2026-10-22 2:24 ` Jiebing Chen
2026-10-26 21:02 ` Mark Brown
2026-10-28 12:20 ` Jiebing Chen
2026-10-21 7:08 ` [PATCH v7 4/5] clk: meson: axg_audio: add S4 support Jiebing Chen via B4 Relay
2026-10-21 15:08 ` Jerome Brunet
2026-10-21 7:08 ` [PATCH v7 5/5] arm64: dts: amlogic: Add Amlogic S4 Audio Jiebing Chen via B4 Relay
2026-10-21 7:53 ` sashiko-bot
2026-10-21 15:08 ` Jerome Brunet
2026-10-22 2:54 ` Jiebing Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028-sparkling-objective-cricket-a428bd@quoll \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.xu@amlogic.com \
--cc=jiebing.chen@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shuai.li@amlogic.com \
--cc=tiwai@suse.com \
--cc=zhe.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox