Linux clock framework development
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Roger Quadros" <rogerq@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Paul Walmsley" <paul@pwsan.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney+clk@redhat.com>,
	"Jerome Brunet" <jbrunet+clk@baylibre.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>, "Andy Yan" <andyshrk@163.com>,
	"Ulf Hansson" <ulfh@kernel.org>,
	linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 5/6] [RFT] ARM: OMAP2+: Convert to dev_clk_get_from_provider()
Date: Thu, 19 Nov 2026 22:50:17 +0100	[thread overview]
Message-ID: <20261119225017.15a7b5cc@kemnade.info> (raw)
In-Reply-To: <683b5b189409e5ee04100044fb615b01cb877f3d.1795094688.git.geert+renesas@glider.be>

On Thu, 19 Nov 2026 14:40:38 +0100
Geert Uytterhoeven <geert+renesas@glider.be> wrote:

> OMAP2+ clock handling uses of_clk_get_from_provider() to obtain clocks
> used for power management, so the latter show up as "deviceless" in the
> consumer column of the clk_summary file in debugfs.
> 
> Fix this by using dev_clk_get_from_provider() instead, letting us pass
> the consumer device, too.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Compile-tested only.
> 
> The first change is probably OK.  The second change may fail if anything
> in the oh->od->pdev->dev chain is not available yet at this point.

Test on OMAP3:

$ diff -u clk-old clk-new
--- clk-old	2026-11-19 22:44:59.810807920 +0100
+++ clk-new	2026-11-19 22:26:52.862531880 +0100
@@ -1,17 +1,17 @@
                                  enable  prepare  protect                                duty  hardware                            connection
    clock                          count    count    count        rate   accuracy phase  cycle    enable   consumer                         id
 ---------------------------------------------------------------------------------------------------------------------------------------------
- oscillator                          0       0        0        26000000    0          0     50000      Y   deviceless                      of_clk_get_from_provider 
+ oscillator                          0       0        0        26000000    0          0     50000      Y   deviceless                      dev_clk_get_from_provider
                                                                                                            deviceless                      no_connection_id         
- secure_32k_fck                      0       1        0        32768       0          0     50000      Y   deviceless                      of_clk_get_from_provider 
+ secure_32k_fck                      0       1        0        32768       0          0     50000      Y   deviceless                      dev_clk_get_from_provider
                                                                                                            deviceless                      no_connection_id         
-    wdt1_fck                         0       0        0        32768       0          0     50000      Y      deviceless                      of_clk_get_from_provider 
+    wdt1_fck                         0       0        0        32768       0          0     50000      Y      deviceless                      dev_clk_get_from_provider
                                                                                                               deviceless                      no_connection_id         
     gpt12_fck                        0       1        0        32768       0          0     50000      Y      48304000.timer                  fck                      
                                                                                                               48304000.target-module          fck                      
-                                                                                                              deviceless                      of_clk_get_from_provider 
+                                                                                                              deviceless                      dev_clk_get_from_provider
                                                                                                               deviceless                      no_connection_id         
- dummy_ck                            0       0        0        0           0          0     50000      Y   deviceless                      of_clk_get_from_provider 
+ dummy_ck                            0       0        0        0           0          0     50000      Y   deviceless                      dev_clk_get_from_provider
                                                                                                            deviceless                      no_connection_id         
  mcbsp_clks                          0       5        0        0           0          0     50000      Y   deviceless                      mcbsp_clks               
                                                                                                            deviceless                      mcbsp_clks               
[...]
Regards,
Andreas
> ---
>  arch/arm/mach-omap2/omap_device.c | 2 +-
>  arch/arm/mach-omap2/omap_hwmod.c  | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> index 77a75b0b9ae69c85..5695e0c8f2392eca 100644
> --- a/arch/arm/mach-omap2/omap_device.c
> +++ b/arch/arm/mach-omap2/omap_device.c
> @@ -73,7 +73,7 @@ static void _add_clkdev(struct omap_device *od, const char *clk_alias,
>  
>  		clkspec.np = of_find_node_by_name(NULL, clk_name);
>  
> -		r = of_clk_get_from_provider(&clkspec);
> +		r = dev_clk_get_from_provider(&od->pdev->dev, &clkspec);
>  
>  		rc = clk_register_clkdev(r, clk_alias,
>  					 dev_name(&od->pdev->dev));
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index 03cd523dff874bb0..5e4123014909d4ac 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -147,6 +147,7 @@
>  #include <asm/system_misc.h>
>  
>  #include "clock.h"
> +#include "omap_device.h"
>  #include "omap_hwmod.h"
>  
>  #include "soc.h"
> @@ -796,7 +797,7 @@ static struct clk *_lookup_clkctrl_clk(struct omap_hwmod *oh)
>  				clkspec.args[0] = addr - provider->addr[0];
>  				clkspec.args[1] = 0;
>  
> -				clk = of_clk_get_from_provider(&clkspec);
> +				clk = dev_clk_get_from_provider(&oh->od->pdev->dev, &clkspec);
>  
>  				pr_debug("%s: %s got %p (offset=%x, provider=%pOF)\n",
>  					 __func__, oh->name, clk,


  reply	other threads:[~2026-11-19 21:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:40 [PATCH 0/6] clk: Improve consumer field in debugfs clk_summary Geert Uytterhoeven
2026-11-19 13:40 ` [PATCH 1/6] clk: Remove unused clk.dev Geert Uytterhoeven
2026-11-19 13:40 ` [PATCH 2/6] clk: Add dev_clk_get_from_provider() Geert Uytterhoeven
2026-11-19 13:40 ` [PATCH 3/6] clk: renesas: Convert to dev_clk_get_from_provider() Geert Uytterhoeven
2026-11-19 13:40 ` [PATCH 4/6] [RFT] drm/rockchip: dw_hdmi: " Geert Uytterhoeven
2026-11-19 13:40 ` [PATCH 5/6] [RFT] ARM: OMAP2+: " Geert Uytterhoeven
2026-11-19 21:50   ` Andreas Kemnade [this message]
2026-11-19 13:40 ` [PATCH 6/6] [RFC] pmdomain: renesas: r8a78000: " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119225017.15a7b5cc@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=aaro.koskinen@iki.fi \
    --cc=andyshrk@163.com \
    --cc=bmasney+clk@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=jbrunet+clk@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=paul@pwsan.com \
    --cc=rogerq@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tony@atomide.com \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox