From: "Heiko Stübner" <heiko@sntech.de>
To: hl <hl@rock-chips.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>,
dbasehore@chromium.org, briannorris@chromium.org,
dianders@chromium.org, linux-rockchip@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: assign clock rate for some cpll child clock
Date: Tue, 20 Mar 2018 08:00:40 +0100 [thread overview]
Message-ID: <22053902.qFbnfPJqGC@diego> (raw)
In-Reply-To: <d92aa74d-7a49-8fbd-5efc-b931210ef0b7@rock-chips.com>
Am Dienstag, 20. März 2018, 03:23:41 CET schrieb hl:
> On Tuesday, March 20, 2018 10:12 AM, Shawn Lin wrote:
> > On 2018/3/20 10:06, Lin Huang wrote:
> >> These clocks do not assign default clock frequency, and use the
> >> default cru register value to get frequency, so if cpll increase
> >> frequency, these clocks also increase their frequency, that may
> >> exceed their signed off frequency. So assign default clock for
> >> them to avoid it.
> >>
> >> NOTE: on none of the boards currently in mainline do we expect
> >> CPLL to be anything other than 800 MHz, but some future boards
> >> might have it. It's still good to be explicit about the clock
> >> rates to make diffing against future boards easier and also to
> >> rely less on BIOS muxing.
> >>
> >> Change-Id: If79368aeda5c51dbf2a3b6659f17052a2ae4a401
> >
> > Should remove Change-Id for future patch(es), thought Heiko may help
> > do it when applied.
>
> Opp, sorry for that.
Yep, I can drop the changeId when applying
next prev parent reply other threads:[~2018-03-20 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 2:06 [PATCH v3 1/2] clk: rockchip: assign correct id for pclk_ddr and hclk_sd in rk3399 Lin Huang
2018-03-20 2:06 ` [PATCH v3 2/2] arm64: dts: rockchip: assign clock rate for some cpll child clock Lin Huang
2018-03-20 2:12 ` Shawn Lin
2018-03-20 2:23 ` hl
2018-03-20 7:00 ` Heiko Stübner [this message]
2018-03-23 8:45 ` Heiko Stuebner
2018-03-23 8:26 ` [PATCH v3 1/2] clk: rockchip: assign correct id for pclk_ddr and hclk_sd in rk3399 Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22053902.qFbnfPJqGC@diego \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=dbasehore@chromium.org \
--cc=dianders@chromium.org \
--cc=hl@rock-chips.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox