Re: [PATCH 0/2] Use APIs in gdsc genpd to switch gdsc mode for venus v4 core

Bryan O'Donoghue
2024-11-23T00:19:01Z

On 22/11/2024 10:31, Renjiang Han wrote:
> The Venus driver requires vcodec GDSC to be ON in SW mode for clock
> operations and move it back to HW mode to gain power benefits. Earlier,
> as there is no interface to switch the GDSC mode from GenPD framework,
> the GDSC is moved to HW control mode as part of GDSC enable callback and
> venus driver is writing to its POWER_CONTROL register to keep the GDSC ON
> from SW whereever required. But the POWER_CONTROL register addresses are
> not constant and can vary across the variants.
>
> Also as per the HW recommendation, the GDSC mode switching needs to be
> controlled from respective GDSC register and this is a uniform approach
> across all the targets. Hence use dev_pm_genpd_set_hwmode() API which
> controls GDSC mode switching using its respective GDSC register.
>
> Signed-off-by: Renjiang Han <quic_renjiang@quicinc.com>
> ---
> Renjiang Han (1):
> venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V4
>
> Taniya Das (1):
> clk: qcom: videocc: Use HW_CTRL_TRIGGER flag for video GDSC's
>
> drivers/clk/qcom/videocc-sc7180.c | 2 +-
> drivers/clk/qcom/videocc-sdm845.c | 4 ++--
> drivers/media/platform/qcom/venus/pm_helpers.c | 10 +++++-----
> 3 files changed, 8 insertions(+), 8 deletions(-)
> ---
> base-commit: 63b3ff03d91ae8f875fe8747c781a521f78cde17
> change-id: 20241122-switch_gdsc_mode-b658ea233c2a
>
> Best regards,

What's your test strategy here ? What platforms have you tested this on ?

What help do you need ?

---
bod