Re: [PATCH 1/2] clk: qcom: videocc: Use HW_CTRL_TRIGGER flag for video GDSC's

Renjiang Han
2024-12-18T11:27:09Z

On 11/26/2024 12:27 AM, Dmitry Baryshkov wrote:
> On Mon, Nov 25, 2024 at 03:14:27PM +0000, Renjiang Han (QUIC) wrote:
>> On Monday, November 25, 2024 9:55 PM, Dmitry Baryshkov wrote:
>>> On Mon, 25 Nov 2024 at 07:31, Renjiang Han (QUIC) <quic_renjiang@quicinc.com> wrote:
>>>> On Saturday, November 23, 2024 8:17 AM, Bryan O'Donoghue wrote:
>>>>> On 23/11/2024 00:05, Dmitry Baryshkov wrote:
>>>>>> This leaves sm7150, sm8150 and sm8450 untouched. Don't they also
>>>>>> need to use HW_CTRL_TRIGGER?
>>>>> I believe the correct list here is anything that is HFI_VERSION_4XX
>>>>> in
>>>>> You can't apply the second patch in this series without ensuring the
>>>>> clock controllers for sdm845 and sm7180
>>>>> grep HFI_VERSION_4XX drivers/media/platform/qcom/venus/core.c
>>>>> drivers/clk/qcom/videocc-sdm845.c
>>>>> drivers/clk/qcom/videocc-sc7180.c
>>>>> Hmm.. that's what this patch does, to be fair my other email was flippant.
>>>>> This is fine in general, once we can get some Tested-by: for it.
>>>>> That's my question - what platforms has this change been tested on ?
>>>>> I can do sdm845 but, we'll need to find someone with 7180 to verify IMO.
>>>> Thanks for your comment. We have run video case with these two patches on sc7180. The result is fine.
>>> A single case, a thorough tests, a mixture of suspend&resume while playing video cases?
>>> Also, can I please reiterate my question: sm7150, sm8150 and sm8450 ?
>>> Should they also be changed to use HW_CTRL_TRIGGER?
>>> Next question, sdm660, msm8996, msm8998: do they support HW_CTRL_TRIGGER?
>> Thanks for your review. The video playback and recording cases include video
>> pause and resume, and full video playback. The results are fine.
>> Also, this change is only for v4 core (HFI_VERSION_4XX ). Therefore, we have only tested it
>> on platforms using v4 core. We have not tried other platforms.
>> sm7150, sm8150 and sm8450 should not use venus v4 core. So they needn't to use HW_CTRL_TRIGGER.
> We don't have venus / iris support for those platforms at all.
> This patch is not about venus, it is about the clock drivers. So
> mentioning venus is quite useless here.
> If these platforms will benefit from HW_CTRL_TRIGGER, then we should
> change them at the same time, before somebody even gets venus/iris on
> them.
Thanks for pointing it out. HW_CTRL_TRIGGER can be used for sm7150,
sm8150 and sm8450. But this flag can't be used for sdm660, msm8996
and msm8998. Because venus doesn't support it on these three
platforms.

--
Best Regards,
Renjiang