Re: [GIT PULL] Rockchip clock changes for 6.15 #1

[Heiko Stuebner <heiko@sntech.de>]

Hi Stephen,

Am Dienstag, 11. März 2025, 19:05:50 MEZ schrieb Stephen Boyd:
> Quoting Heiko Stuebner (2025-03-08 10:23:39)
> > Hi Mike, Stephen,
> > 
> > please find below a pull-request with Rockchip clock change for 6.15
> > The new year started with a flurry of activity it seems :-) .
> > 
> > 
> > Please pull.
> > 
> > Thanks
> > Heiko
> > 
> > 
> > The following changes since commit 2014c95afecee3e76ca4a56956a936e23283f05b:
> > 
> >   Linux 6.14-rc1 (2025-02-02 15:39:26 -0800)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git tags/v6.15-rockchip-clk1
> > 
> > for you to fetch changes up to f863d4cc79a7e2f8c734d1fac84dc275805f41c7:
> > 
> >   clk: rockchip: Add clock controller for the RK3562 (2025-03-02 17:51:51 +0100)
> > 
> > ----------------------------------------------------------------
> 
> Thanks. Pulled into clk-next
> 
> Did you see this warning?
> 
> drivers/clk/rockchip/rst-rk3562.c:21:57: error: initialized field overwritten [-Werror=override-init]
>    21 | #define RK3562_DDRCRU_RESET_OFFSET(id, reg, bit) [id] = (0x20000*4 + reg * 16 + bit)
>       |                                                         ^
> drivers/clk/rockchip/rst-rk3562.c:266:9: note: in expansion of macro 'RK3562_DDRCRU_RESET_OFFSET'
>   266 |         RK3562_DDRCRU_RESET_OFFSET(SRST_P_DDR_PHY, 0, 8),
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/rockchip/rst-rk3562.c:21:57: note: (near initialization for 'rk3562_register_offset[173]')
>    21 | #define RK3562_DDRCRU_RESET_OFFSET(id, reg, bit) [id] = (0x20000*4 + reg * 16 + bit)
>       |                                                         ^
> drivers/clk/rockchip/rst-rk3562.c:266:9: note: in expansion of macro 'RK3562_DDRCRU_RESET_OFFSET'
>   266 |         RK3562_DDRCRU_RESET_OFFSET(SRST_P_DDR_PHY, 0, 8),
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors


interestingly, this did not turn up in my build test.
But that splat is really helpful too, because it made it easy to see
that one of the ids is doubled in the dt-binding header.

include/dt-bindings/reset/rockchip,rk3562-cru.h:

#define SRST_P_DDR_HWLP		173
#define SRST_P_DDR_PHY			173


I'll fix up the double id.


Out of curiosity, what toolchain was that?


Thanks
Heiko