Re: [PATCH 5/5] clk: sunxi-ng: d1: Add CAN bus gates and resets

Krzysztof Kozlowski
2022-11-27T20:52:00Z

On 26/11/2022 20:13, Samuel Holland wrote:
> From: Fabien Poussin <fabien.poussin@gmail.com>
>
> The D1 CCU contains gates and resets for two CAN buses. While the CAN
> bus controllers are only documented for the T113 SoC, the CCU is the
> same across all SoC variants.
>
> Signed-off-by: Fabien Poussin <fabien.poussin@gmail.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> drivers/clk/sunxi-ng/ccu-sun20i-d1.c | 11 +++++++++++
> drivers/clk/sunxi-ng/ccu-sun20i-d1.h | 2 +-
> include/dt-bindings/clock/sun20i-d1-ccu.h | 2 ++
> include/dt-bindings/reset/sun20i-d1-ccu.h | 2 ++

Don't mix bindings with driver changes. Checkpatch should complain here...

Best regards,
Krzysztof