From: "Liang He" <windhl@126.com>
To: "Stephen Boyd" <sboyd@kernel.org>, Conor.Dooley@microchip.com
Cc: linus.walleij@linaro.org, mturquette@baylibre.com,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH v2] drivers: clk: (clk-nomadik) Add missing of_node_put()
Date: Thu, 16 Jun 2022 16:24:46 +0800 (CST) [thread overview]
Message-ID: <22796950.5fb1.1816b9d67a7.Coremail.windhl@126.com> (raw)
In-Reply-To: <20220616060225.3495EC34114@smtp.kernel.org>
At 2022-06-16 14:02:23, "Stephen Boyd" <sboyd@kernel.org> wrote:
>Same subject line comment applies here. Look at previous patches to the
>file.
Sorry, what do you mean same subject line comment?
I add a [PATCH v2] tag when I use 'git format-patch -v 2'.
You mean the two commit has same subject content?
Sorry, I am a beginner to submit patch commit.
>
>Quoting Liang He (2022-06-15 20:24:48)
>> diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
>> index bad2677e11ae..48d5772b36a5 100644
>> --- a/drivers/clk/clk-nomadik.c
>> +++ b/drivers/clk/clk-nomadik.c
>> @@ -99,7 +99,7 @@ static void __init nomadik_src_init(void)
>> if (!src_base) {
>> pr_err("%s: must have src parent node with REGS (%pOFn)\n",
>> __func__, np);
>> - return;
>> + goto out_put;
>> }
>>
>> /* Set all timers to use the 2.4 MHz TIMCLK */
>> @@ -132,6 +132,9 @@ static void __init nomadik_src_init(void)
>> }
>> writel(val, src_base + SRC_XTALCR);
>> register_reboot_notifier(&nomadik_clk_reboot_notifier);
>> +
>> +output:
>> + of_node_put(np);
>
>tabbed incorrectly?
Sorry for this incorrct tab setting.
next prev parent reply other threads:[~2022-06-16 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 3:24 [PATCH v2] drivers: clk: (clk-nomadik) Add missing of_node_put() Liang He
2022-06-16 6:02 ` Stephen Boyd
2022-06-16 8:24 ` Liang He [this message]
2022-06-16 14:08 ` kernel test robot
2022-06-16 14:24 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22796950.5fb1.1816b9d67a7.Coremail.windhl@126.com \
--to=windhl@126.com \
--cc=Conor.Dooley@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox