linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: robh@kernel.org, WeiHao Li <cn.liweihao@gmail.com>
Cc: hjc@rock-chips.com, andy.yan@rock-chips.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org,
	WeiHao Li <cn.liweihao@gmail.com>
Subject: Re: [PATCH v1 0/7] drm/rockchip: Add MIPI DSI support for RK3368
Date: Sun, 31 Aug 2025 17:09:55 +0200	[thread overview]
Message-ID: <22816630.EfDdHjke4D@diego> (raw)
In-Reply-To: <20250831104855.45883-1-cn.liweihao@gmail.com>

Hi,

Am Sonntag, 31. August 2025, 12:48:48 Mitteleuropäische Sommerzeit schrieb WeiHao Li:
> This series adds MIPI DSI support for the Rockchip RK3368 SoC, enabling
> native display connectivity through the MIPI DSI host controller and
> PHY. The changes span multiple subsystems, including clock control,
> DRM/VOP integration, DSI controller binding, and PHY driver updates.
> 
> Key changes:
>   - Update the Rockchip MIPI DSI PHY driver to preperly handle RK3368
>     phy initialization.

which patch is doing this, because I don't see any phy-related change

>   - Add missing lut_size of vop_data for RK3368.
>   - Add missing clock ID SCLK_MIPIDSI_24M to the RK3368 CRU driver,
>     which is required for enabling the 24MHz reference clock.
>   - Add MIPI DSI node to rk3368.dtsi with correct clocks, resets,
>     and register mappings.
> 
> These changes were tested on a RK3368-based board with a MIPI DSI
> panel [1]. The display boots successfully with console output.
> 
> [1] https://ieiao.github.io/wiki/embedded-dev/rockchip/rk3368

Do you plan on submitting this board to mainline?
Because having an actual user of the code you're adding would
be really really nice.

Thanks
Heiko

> 
> Tested-by: WeiHao Li <cn.liweihao@gmail.com>
> Signed-off-by: WeiHao Li <cn.liweihao@gmail.com>
> 
> WeiHao Li (7):
>   drm/rockchip: dsi: Add support for RK3368
>   drm/rockchip: vop: add lut_size for RK3368 vop_data
>   dt-bindings: clock: rk3368: Add SCLK_MIPIDSI_24M
>   clk: rockchip: use clock ids for SCLK_MIPIDSI_24M on rk3368
>   ARM: dts: rockchip: Add display subsystem for RK3368
>   ARM: dts: rockchip: Add D-PHY for RK3368
>   ARM: dts: rockchip: Add DSI for RK3368
> 
>  arch/arm64/boot/dts/rockchip/rk3368.dtsi      | 79 +++++++++++++++++++
>  drivers/clk/rockchip/clk-rk3368.c             |  2 +-
>  .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c   | 20 +++++
>  drivers/gpu/drm/rockchip/rockchip_vop_reg.c   |  1 +
>  include/dt-bindings/clock/rk3368-cru.h        |  1 +
>  5 files changed, 102 insertions(+), 1 deletion(-)
> 
> 





  parent reply	other threads:[~2025-08-31 15:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-31 10:48 [PATCH v1 0/7] drm/rockchip: Add MIPI DSI support for RK3368 WeiHao Li
2025-08-31 10:48 ` [PATCH v1 1/7] drm/rockchip: dsi: Add " WeiHao Li
2025-09-03 12:07   ` Heiko Stuebner
2025-09-03 13:37     ` 李维豪
2025-08-31 10:48 ` [PATCH v1 2/7] drm/rockchip: vop: add lut_size for RK3368 vop_data WeiHao Li
2025-09-03 12:16   ` Heiko Stuebner
2025-08-31 10:48 ` [PATCH v1 3/7] dt-bindings: clock: rk3368: Add SCLK_MIPIDSI_24M WeiHao Li
2025-08-31 15:00   ` Heiko Stübner
2025-09-01  0:17     ` 李维豪
2025-09-02  6:49       ` Heiko Stuebner
2025-09-03 13:22         ` 李维豪
2025-09-01 21:32   ` Rob Herring (Arm)
2025-08-31 10:48 ` [PATCH v1 4/7] clk: rockchip: use clock ids for SCLK_MIPIDSI_24M on rk3368 WeiHao Li
2025-08-31 10:48 ` [PATCH v1 5/7] ARM: dts: rockchip: Add display subsystem for RK3368 WeiHao Li
2025-08-31 15:04   ` Heiko Stübner
2025-09-01  0:20     ` 李维豪
2025-08-31 10:48 ` [PATCH v1 6/7] ARM: dts: rockchip: Add D-PHY " WeiHao Li
2025-08-31 15:06   ` Heiko Stübner
2025-09-01  0:33     ` 李维豪
2025-08-31 10:48 ` [PATCH v1 7/7] ARM: dts: rockchip: Add DSI " WeiHao Li
2025-08-31 15:09 ` Heiko Stübner [this message]
2025-09-01  0:46   ` [PATCH v1 0/7] drm/rockchip: Add MIPI DSI support " 李维豪
2025-09-02 13:17 ` Rob Herring (Arm)
2025-09-03 12:19 ` (subset) " Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22816630.EfDdHjke4D@diego \
    --to=heiko@sntech.de \
    --cc=andy.yan@rock-chips.com \
    --cc=cn.liweihao@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hjc@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).