Linux clock framework development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-watchdog@vger.kernel.org,
	Prabhakar <prabhakar.csengg+renesas@gmail.com>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v3 1/8] dt-bindings: clock: renesas: Split out RZ/T2H CPG binding
Date: Mon, 20 Jul 2026 12:53:13 +0200	[thread overview]
Message-ID: <2323f9bd-0b1e-41be-8c8d-6906b66b625f@kernel.org> (raw)
In-Reply-To: <CA+V-a8tfCL58j2TvoO1VhhDAZf=8LB89R4O0SycLghYGf7Rr4w@mail.gmail.com>

On 20/07/2026 12:50, Lad, Prabhakar wrote:
> Hi Krzysztof,
> 
> On Mon, Jul 20, 2026 at 6:55 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Thu, Jul 16, 2026 at 01:34:27PM +0100, Prabhakar wrote:
>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>
>>> Move the RZ/T2H and RZ/N2H clock controller bindings from the generic
>>> renesas,cpg-mssr.yaml schema into a dedicated binding.
>>>
>>> Unlike the traditional Renesas CPG/MSSR block, the RZ/T2H and RZ/N2H
>>> system controller integrates additional functionality beyond clock and
>>> module-stop control, including reset control, clock monitor support,
>>> write-protection registers and other system management features.
>>
>> Nothing of above differences got reflected in the code, so I do not
>> understand this reasoning. Binding is exactly the same as the old one.
>>
> A syscon regmap is implemented [0] as part of the RZ/T2H CPG driver.
> Since the RZ/T2H clock driver uses this syscon wrapper, a function
> pointer is implemented to handle the RZ/T2H-specific configuration.
> 
> Also, as the initial implementation used separate device tree nodes,
> Geert suggested splitting this binding schema off into a dedicated
> file [1].
> 

I still miss the difference. Can you point me (can be short diff) to
actual difference in this binding?

Best regards,
Krzysztof

  reply	other threads:[~2026-07-20 10:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 12:34 [PATCH v3 0/8] Add syscon support for Renesas RZ/T2H & RZ/N2H in CPG/MSSR driver Prabhakar
2026-07-16 12:34 ` [PATCH v3 1/8] dt-bindings: clock: renesas: Split out RZ/T2H CPG binding Prabhakar
2026-07-20  5:54   ` Krzysztof Kozlowski
2026-07-20 10:50     ` Lad, Prabhakar
2026-07-20 10:53       ` Krzysztof Kozlowski [this message]
2026-07-20 11:13         ` Lad, Prabhakar
2026-07-16 12:34 ` [PATCH v3 2/8] clk: renesas: r9a09g077: Register SYSC regmap Prabhakar
2026-07-16 12:34 ` [PATCH v3 3/8] arm64: dts: renesas: r9a09g077: Adjust CPG register region sizes Prabhakar
2026-07-16 12:34 ` [PATCH v3 4/8] arm64: dts: renesas: r9a09g087: " Prabhakar
2026-07-16 12:34 ` [PATCH v3 5/8] dt-bindings: watchdog: renesas,r9a09g057-wdt: Add CPG/MSSR syscon support Prabhakar
2026-07-22 17:46   ` Rob Herring (Arm)
2026-07-16 12:34 ` [PATCH v3 6/8] watchdog: rzv2h: Add syscon support for WDTDCR Prabhakar
2026-07-16 12:34 ` [PATCH v3 7/8] arm64: dts: renesas: r9a09g077: Use CPG/MSSR syscon for WDTDCR access Prabhakar
2026-07-16 12:34 ` [PATCH v3 8/8] arm64: dts: renesas: r9a09g087: " Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2323f9bd-0b1e-41be-8c8d-6906b66b625f@kernel.org \
    --to=krzk@kernel.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=bmasney@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=prabhakar.csengg+renesas@gmail.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox