From: <Claudiu.Beznea@microchip.com>
To: <krzysztof.kozlowski@linaro.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] memory: atmel-sdramc: remove the driver
Date: Tue, 3 Jan 2023 11:18:14 +0000 [thread overview]
Message-ID: <23389f8e-daf4-67ca-1e3b-c5a6433f3986@microchip.com> (raw)
In-Reply-To: <9054a7cd-2993-840f-1f4b-7837b43a1800@linaro.org>
On 03.01.2023 12:06, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 03/01/2023 11:00, Claudiu.Beznea@microchip.com wrote:
>> Hi, Krzysztof,
>>
>> On 08.12.2022 13:45, Claudiu Beznea wrote:
>>> Driver does only clock request + enable for DDR clocks. DDR clocks are
>>> enabled by bootloader and need to stay that way in Linux. To avoid having
>>> these clocks disabled by clock subsystem in case there are no Linux
>>> consumers for them the clocks were marked as critical in clock drivers.
>>> With this, there is no need to have a separate driver that only does
>>> clock request + enable.
>>>
>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>>
>> As this patch depends on patch 1/3 from this series, can I have your ack
>> for it to take it though clock tree?
>
> Uh, why does it depend? I understood the changset is bisectable and
> removal of unneeded driver will happen later. Otherwise it is not
> bisectable...
AT91 devices will fail to boot if this patch is applied and 1/3 is not
there. This is because clock framework will disable DDR clocks because
there will be no consumer for them.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-01-03 11:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 11:45 [PATCH 0/3] clk: at91: mark ddr clocks as critical Claudiu Beznea
2022-12-08 11:45 ` [PATCH 1/3] " Claudiu Beznea
2023-01-12 10:28 ` Claudiu.Beznea
2022-12-08 11:45 ` [PATCH 2/3] memory: atmel-sdramc: remove the driver Claudiu Beznea
2023-01-03 10:00 ` Claudiu.Beznea
2023-01-03 10:06 ` Krzysztof Kozlowski
2023-01-03 11:18 ` Claudiu.Beznea [this message]
2023-01-03 12:00 ` Krzysztof Kozlowski
2023-01-03 12:45 ` Claudiu.Beznea
2023-01-03 13:17 ` Krzysztof Kozlowski
2023-01-03 14:29 ` Claudiu.Beznea
2022-12-08 11:45 ` [PATCH 3/3] clk: at91: do not compile dt-compat.c for sama7g5 and sam9x60 Claudiu Beznea
2022-12-08 14:39 ` Alexandre Belloni
2022-12-08 15:17 ` Claudiu.Beznea
2023-01-12 10:28 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23389f8e-daf4-67ca-1e3b-c5a6433f3986@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox