From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 385CAC00A89 for ; Mon, 2 Nov 2020 21:01:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C020F2072C for ; Mon, 2 Nov 2020 21:01:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=vt-edu.20150623.gappssmtp.com header.i=@vt-edu.20150623.gappssmtp.com header.b="Zj0XH4Gp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726342AbgKBVBn (ORCPT ); Mon, 2 Nov 2020 16:01:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbgKBVBn (ORCPT ); Mon, 2 Nov 2020 16:01:43 -0500 Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04A0FC061A04 for ; Mon, 2 Nov 2020 13:01:43 -0800 (PST) Received: by mail-qv1-xf43.google.com with SMTP id b11so6791105qvr.9 for ; Mon, 02 Nov 2020 13:01:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:in-reply-to:references:mime-version :content-transfer-encoding:date:message-id; bh=sfssJoSVarUrVMLVURV+BvhAdC7/uwArT8ZmhaNO1+Y=; b=Zj0XH4GpUc6+gpMRh2RhlFy5ROiQJ/QdeeWeLLNEhIH/tedSB7zeX1UfCOgmwMQJ2b J8JrNgPJiXdnGVTB+1pyA5lOUruh706QskZmam4gGhKW+odm+4SC3AD67PNqO1QvNkMW VHxflaF8RUMBRUbTdfvrsPS6cBRMxscKQ+co/+7DDODfrBtf7A9+1Y+OTl04xARGGv/B MM8bccZPgF71lc7IeQbdKqo3CUMRNloPObxAnpQGohyRKjVP8Uwyh3QevOqv/gRgVBl8 Es+nm53gtl+jRCr9So8QaCgUrUGUq/MqaVu3sW+uCS2HIwO5hkeZVRra+uLeNRdIbdoF zBrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=sfssJoSVarUrVMLVURV+BvhAdC7/uwArT8ZmhaNO1+Y=; b=JYyEV2uU0GO+mlFFtZqNJ4DfGa4/RDtLbpaq1lI4ie1qePOev0jbGv+bBABEZkxNTD WImPHLW8DLwZLS6qx5ndLUFmzmsLYfgI8kJQivQR5WOst1YVfWDJAO/WKPxnTUaeCTnV VzGEeWwZcRd3pWzxuFz0wAfYrYa5fp5rTQ+9atljOQ+YjaBh51r5uyTXmbyuqHJbD4mc z0w06JgREzpjbUIrVSPh4m9j2End7gG7ACA4hhlfrhDZ8rjUbY6VFp0PFHPG6TDtpdVI h+XHkY9+H4hsQTBpp4RvcI+FIm2w01HEdgKfuoocFAJL+9X9w6ecGUsktWKHMI8TA5lo I0sg== X-Gm-Message-State: AOAM531WwKqB4Aup4tSaSRSmE/EJhSQlxatLHIxNMjFD/u2bjspGYIH5 T7cT5bLr6jWqhEFRH9EAN35QkQ== X-Google-Smtp-Source: ABdhPJxjFuxtaEy0PCizL0CmEhKqRKfoe98V4mJlXUms3rhVSIcHT8UkAbapQUXa2aa8X7flf2Dn+g== X-Received: by 2002:a0c:f3d0:: with SMTP id f16mr15065713qvm.42.1604350902180; Mon, 02 Nov 2020 13:01:42 -0800 (PST) Received: from turing-police ([2601:5c0:c380:d61::359]) by smtp.gmail.com with ESMTPSA id y3sm8751323qto.2.2020.11.02.13.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 13:01:40 -0800 (PST) Sender: Valdis Kletnieks From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Randy Dunlap Cc: Dong Aisheng , Michael Turquette , Shawn Guo , Stephen Boyd , Sascha Hauer , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o In-Reply-To: <6e5a8fdb-0a02-5eae-ca1f-37df8a454e34@infradead.org> References: <208469.1604318525@turing-police> <6e5a8fdb-0a02-5eae-ca1f-37df8a454e34@infradead.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1604350899_216810P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Mon, 02 Nov 2020 16:01:39 -0500 Message-ID: <238534.1604350899@turing-police> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --==_Exmh_1604350899_216810P Content-Type: text/plain; charset=us-ascii On Mon, 02 Nov 2020 09:15:20 -0800, Randy Dunlap said: > also > Reported-by: kernel test robot > > However, this driver does not directly use . Just my luck - I looked at 3 or 4 other things that include of_platform.h and they all *did* include module.h. > platform_device.h #includes , which is where the > problem lies: > > uses macros that are provided by > so should #include . > > and that fixes this commit: > > commit 4c002c978b7f2f2306d53de051c054504af920a9 > Author: Greg Kroah-Hartman > Date: Mon Dec 9 20:33:03 2019 +0100 > > device.h: move 'struct driver' stuff out to device/driver.h OK.. who's going to do that? Me, or Randy, or Greg? --==_Exmh_1604350899_216810P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBX6BzsgdmEQWDXROgAQKfjg//RIaEOb6EyTQqKOPfGtJ4KcMOdHgJwcC/ tYMiOn2Em2wycFf71WP/tBsIDqUXcPVUDfU5zyQPYPKjbRJjMUe1PraO3qrSlhke N6XwkcCo4V16PVFJFpcdVJfxo6nPxlIZ9lq3Hd4T26gnUPfS9p5rPHtGNYDAKyD8 c3mlwDN3inQnuBuON73p7pS+OopVJHjmU6zvvEgbsiJcUpoJk+13uKvTG4RbWmNz i1PKb1+dk4uEETAZCMftFqfji80ugWUuMXKRCapS12nqBOkLgxUmWED5XZJC4H5X pogktUAGKxTivLqhVTz/JWvrAnACKiM1OUfRCNcJh40hgt3wGvuUxLpALT2Rfiqp ANRl4q2UzivUIhbee+V9h4m+ZthBkOmHU7nfDQDeZYzKHAGthUfKGdmTXEG2dAmH R5p7E/k4GfKvBdGYp86LL/s+wlARvqbfg/R0fTIlsTgfPsnOkigP41s5w0Ccm656 7YIXHJomsOL8cjWyvLI/FpbhFs92c11Pt8nlKj2PEl+M9GjoL7gp7NSSJM7DaEri UrEcmlaNN12hu5giSsJ7N1olVqkgMqylM0JptP33eObCC5uHx+Tz/sOWpFrKCuBi kZVXKKFL6QOe/fAVvYPfcP1ThTbRv5Giv4iDLVB6AXxre74nb7QbUYPDeu18DIMv bcY4c26AjmI= =PXZH -----END PGP SIGNATURE----- --==_Exmh_1604350899_216810P--