From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
ABE Hiroshige <hiroshige.abe.zc@renesas.com>,
Takeshi Kihara <takeshi.kihara.df@renesas.com>
Subject: Re: [PATCH] clk: renesas: r8a7796: Add FDP clock
Date: Tue, 02 Jan 2018 17:54:44 +0200 [thread overview]
Message-ID: <2397934.0Hfvr3l64P@avalon> (raw)
In-Reply-To: <1514906503-8535-1-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Tuesday, 2 January 2018 17:21:43 EET Geert Uytterhoeven wrote:
> From: ABE Hiroshige <hiroshige.abe.zc@renesas.com>
>
> This patch adds FDP1-0 clock to the R8A7796 SoC.
>
> Signed-off-by: ABE Hiroshige <hiroshige.abe.zc@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> [geert: s/fdp0/fdp1-0/]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
I can't verify the parent clock, but apart from that,
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> This gets rid of the following error messages during boot and system
> resume:
>
> renesas-cpg-mssr e6150000.clock-controller: Cannot get module clock 119:
> -2 rcar_fdp1 fe940000.fdp1: failed to add to PM domain a3vc: -2
>
> To be queued in clk-renesas-for-v4.16.
> ---
> drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> b/drivers/clk/renesas/r8a7796-cpg-mssr.c index
> 83a68e51e4ec1d12..dfb267a92f2a20d3 100644
> --- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> @@ -117,6 +117,7 @@ static const struct cpg_core_clk r8a7796_core_clks[]
> __initconst = { };
>
> static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
> + DEF_MOD("fdp1-0", 119, R8A7796_CLK_S0D1),
> DEF_MOD("scif5", 202, R8A7796_CLK_S3D4),
> DEF_MOD("scif4", 203, R8A7796_CLK_S3D4),
> DEF_MOD("scif3", 204, R8A7796_CLK_S3D4),
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-01-02 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 15:21 [PATCH] clk: renesas: r8a7796: Add FDP clock Geert Uytterhoeven
2018-01-02 15:54 ` Laurent Pinchart [this message]
2018-01-04 10:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2397934.0Hfvr3l64P@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=hiroshige.abe.zc@renesas.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=takeshi.kihara.df@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox