From: Manu Gautam <mgautam@codeaurora.org>
To: Amit Nischal <anischal@codeaurora.org>, Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845
Date: Wed, 18 Apr 2018 22:08:41 +0530 [thread overview]
Message-ID: <23b9ca5a-b708-f142-9906-3f3eadd8c26a@codeaurora.org> (raw)
In-Reply-To: <f563532b5c43960a61ae12a37a131be8@codeaurora.org>
Hi Amit,
On 4/18/2018 6:33 PM, Amit Nischal wrote:
>>> + /* Disable the GPLL0 active input to MMSS and GPU via MISC registers */
>>> + regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3);
>>> + regmap_update_bits(regmap, 0x71028, 0x3, 0x3);
>>
>> I think we'll have to throw in the pipe clk branch stuff in here too?
>> And then drop the pipe clks from the driver?
>
> All the USB pipe clocks would be taken care. The PCIE pipe branch
> clocks would have to be explicitly disabled so as to retain the
> memory logic. Otherwise, it would lead to memory corruption in case
> the external source is directly disabled without disabling the branch clock.
PHY driver is same for both USB and PCIE and both PHYs use pipe_clk.
If there is indeed some limitation and pipe_clk cant be left enabled
always then I will suggest to not change pipe_clk handling for USB as well.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-04-18 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 13:22 [PATCH v3 0/3] Misc patches to support clocks for SDM845 Amit Nischal
2018-04-03 13:22 ` [PATCH v3 1/3] clk: qcom: Clear hardware clock control bit of RCG Amit Nischal
2018-04-03 13:22 ` [PATCH v3 2/3] clk: qcom: Configure the RCGs to a safe source as needed Amit Nischal
2018-04-03 13:22 ` [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845 Amit Nischal
2018-04-17 3:51 ` Stephen Boyd
2018-04-18 13:03 ` Amit Nischal
2018-04-18 16:38 ` Manu Gautam [this message]
2018-04-18 23:31 ` Stephen Boyd
2018-04-18 23:34 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23b9ca5a-b708-f142-9906-3f3eadd8c26a@codeaurora.org \
--to=mgautam@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=anischal@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=okukatla@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox