Linux clock framework development
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-clk@vger.kernel.org,
	kbuild test robot <fengguang.wu@intel.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH] clk: fix compile testing of scpi clk driver
Date: Tue, 28 Nov 2017 07:58:23 +0100	[thread overview]
Message-ID: <24058ecb-9f12-f7e1-503d-bd98eb894c6c@gmail.com> (raw)

We now have a hard dependency on ARM_SCPI_PROTOCOL and may end up with
the following error:
ERROR: "get_scpi_ops" [drivers/clk/clk-scpi.ko] undefined!
Fix this by removing COMPILE_TEST from COMMON_CLK_SCPI dependencies.

Fixes: f7fee8be06a6 "firmware: arm_scpi: remove default for get_scpi_ops if not reachable"
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/clk/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 1c4e1aa67..fe6fd705f 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -64,7 +64,7 @@ config COMMON_CLK_HI655X
 
 config COMMON_CLK_SCPI
 	tristate "Clock driver controlled via SCPI interface"
-	depends on ARM_SCPI_PROTOCOL || COMPILE_TEST
+	depends on ARM_SCPI_PROTOCOL
 	  ---help---
 	  This driver provides support for clocks that are controlled
 	  by firmware that implements the SCPI interface.
-- 
2.15.0


             reply	other threads:[~2017-11-28  6:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28  6:58 Heiner Kallweit [this message]
2017-11-29 17:04 ` [PATCH] clk: fix compile testing of scpi clk driver Stephen Boyd
2017-11-29 20:37   ` Heiner Kallweit
2017-12-04  2:25     ` Sudeep Holla
2017-12-04  2:25 ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24058ecb-9f12-f7e1-503d-bd98eb894c6c@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox