From: Stephen Boyd <sboyd@kernel.org>
To: Michael J. Ruhl <michael.j.ruhl@intel.com>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Russell King <linux@armlinux.org.uk>,
Michael Turquette <mturquette@baylibre.com>,
andriy.shevchenko@linux.intel.com,
Michael J. Ruhl <michael.j.ruhl@intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH v3] clkdev: Update clkdev id usage to allow for longer names
Date: Wed, 28 Feb 2024 14:14:48 -0800 [thread overview]
Message-ID: <24963d5f5a964f7620a4aa1cf5769d62.sboyd@kernel.org> (raw)
In-Reply-To: <20240223202556.2194021-1-michael.j.ruhl@intel.com>
Quoting Michael J. Ruhl (2024-02-23 12:25:56)
> clkdev DEV ID information is limited to an array of 20 bytes
> (MAX_DEV_ID). It is possible that the ID could be longer than
> that. If so, the lookup will fail because the "real ID" will
> not match the copied value.
>
> For instance, generating a device name for the I2C Designware
> module using the PCI ID can result in a name of:
>
> i2c_designware.39424
>
> clkdev_create() will store:
>
> i2c_designware.3942
>
> The stored name is one off and will not match correctly during probe.
>
> Increase the size of the ID to allow for a longer name.
>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2024-02-28 22:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 20:25 [PATCH v3] clkdev: Update clkdev id usage to allow for longer names Michael J. Ruhl
2024-02-26 15:12 ` Andy Shevchenko
2024-02-28 22:14 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24963d5f5a964f7620a4aa1cf5769d62.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael.j.ruhl@intel.com \
--cc=mturquette@baylibre.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox