From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jacky Huang <ychuang570808@gmail.com>, Rob Herring <robh@kernel.org>
Cc: p.zabel@pengutronix.de, arnd@arndb.de, jirislaby@kernel.org,
schung@nuvoton.com, tmaimon77@gmail.com,
devicetree@vger.kernel.org, catalin.marinas@arm.com,
gregkh@linuxfoundation.org, sboyd@kernel.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, will@kernel.org,
Jacky Huang <ychuang3@nuvoton.com>,
lee@kernel.org, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, mjchen@nuvoton.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 06/10] dt-bindings: serial: Document ma35d1 uart controller
Date: Mon, 8 May 2023 10:05:08 +0200 [thread overview]
Message-ID: <25b2fcf6-6ba1-8e51-59e1-2dcf84b856bc@linaro.org> (raw)
In-Reply-To: <a62d278c-f47c-fa97-185e-b81ff4b28a4c@gmail.com>
On 08/05/2023 09:01, Jacky Huang wrote:
>
>
> On 2023/5/8 下午 02:31, Krzysztof Kozlowski wrote:
>> On 08/05/2023 05:26, Rob Herring wrote:
>>> On Mon, 08 May 2023 02:59:32 +0000, Jacky Huang wrote:
>>>> From: Jacky Huang <ychuang3@nuvoton.com>
>>>>
>>>> Add documentation that describes the nuvoton ma35d1 UART driver bindings.
>>>>
>>>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> ---
>>>> .../serial/nuvoton,ma35d1-serial.yaml | 48 +++++++++++++++++++
>>>> 1 file changed, 48 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml
>>>>
>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>>
>>> yamllint warnings/errors:
>>>
>>> dtschema/dtc warnings/errors:
>>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short
>>> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
>>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
>>> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
>>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
>>> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
>>> Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.example.dts:25:18: fatal error: dt-bindings/clock/nuvoton,ma35d1-clk.h: No such file or directory
>>> 25 | #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> compilation terminated.
>>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.example.dtb] Error 1
>> This however is related, although might be coming from earlier failure.
>> I assume you run the check and you do not see any errors?
>>
>> Best regards,
>> Krzysztof
>>
>
> Dear Krzysztof,
>
> Thank you for your review.
>
> Of course I have run the check.
> I did not see any errors, because I have
> "dt-bindings/clock/nuvoton,ma35d1-clk.h".
> This patch 6/10 depends on path 3/10 which include
> "dt-bindings/clock/nuvoton,ma35d1-clk.h".
> Should I combine this patch 6/10 into patch 3/10?
No, it's fine. If you got the reviews and acks and no reports from
kernel test robot, you can go in few days with Arnd's request and send
everything to soc@.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-08 8:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 2:59 [PATCH v10 00/10] Introduce Nuvoton ma35d1 SoC Jacky Huang
2023-05-08 2:59 ` [PATCH v10 01/10] arm64: Kconfig.platforms: Add config for Nuvoton MA35 platform Jacky Huang
2023-05-08 2:59 ` [PATCH v10 02/10] arm64: defconfig: Add support for Nuvoton MA35 family SoCs Jacky Huang
2023-05-08 2:59 ` [PATCH v10 03/10] dt-bindings: clock: nuvoton: add binding for ma35d1 clock controller Jacky Huang
2023-05-08 3:26 ` Rob Herring
2023-05-08 6:30 ` Krzysztof Kozlowski
2023-05-08 2:59 ` [PATCH v10 04/10] dt-bindings: reset: nuvoton: Document ma35d1 reset control Jacky Huang
2023-05-08 3:26 ` Rob Herring
2023-05-08 2:59 ` [PATCH v10 05/10] dt-bindings: arm: Add initial bindings for Nuvoton platform Jacky Huang
2023-05-08 3:26 ` Rob Herring
2023-05-08 2:59 ` [PATCH v10 06/10] dt-bindings: serial: Document ma35d1 uart controller Jacky Huang
2023-05-08 3:26 ` Rob Herring
2023-05-08 6:31 ` Krzysztof Kozlowski
2023-05-08 7:01 ` Jacky Huang
2023-05-08 8:05 ` Krzysztof Kozlowski [this message]
2023-05-08 8:15 ` Jacky Huang
2023-05-08 2:59 ` [PATCH v10 07/10] arm64: dts: nuvoton: Add initial ma35d1 device tree Jacky Huang
2023-05-08 2:59 ` [PATCH v10 08/10] clk: nuvoton: Add clock driver for ma35d1 clock controller Jacky Huang
2023-05-08 10:52 ` Ilpo Järvinen
2023-05-09 0:58 ` Jacky Huang
2023-05-08 2:59 ` [PATCH v10 09/10] reset: Add Nuvoton ma35d1 reset driver support Jacky Huang
2023-05-08 8:20 ` Philipp Zabel
2023-05-08 11:00 ` Ilpo Järvinen
2023-05-09 1:09 ` Jacky Huang
2023-05-08 2:59 ` [PATCH v10 10/10] tty: serial: Add Nuvoton ma35d1 serial " Jacky Huang
2023-05-09 10:17 ` Ilpo Järvinen
2023-05-09 12:14 ` Arnd Bergmann
2023-05-09 12:25 ` Ilpo Järvinen
2023-05-09 12:32 ` Arnd Bergmann
2023-05-10 1:26 ` Jacky Huang
2023-05-10 10:57 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25b2fcf6-6ba1-8e51-59e1-2dcf84b856bc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mjchen@nuvoton.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=schung@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=will@kernel.org \
--cc=ychuang3@nuvoton.com \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox