From: Bryan O'Donoghue <bod@kernel.org>
To: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v5 5/6] clk: qcom: camcc-x1p42100: Add support for camera clock controller
Date: Thu, 7 May 2026 09:15:48 +0100 [thread overview]
Message-ID: <26191034-ad27-4559-a845-14841c075a4c@kernel.org> (raw)
In-Reply-To: <20260507-purwa-videocc-camcc-v5-5-fc3af4130282@oss.qualcomm.com>
On 07/05/2026 06:38, Jagadeesh Kona wrote:
> +static const struct alpha_pll_config cam_cc_pll1_config = {
> + .l = 0x25,
> + .alpha = 0xeaaa,
> + .config_ctl_val = 0x20485699,
> + .config_ctl_hi_val = 0x00182261,
> + .config_ctl_hi1_val = 0x82aa299c,
> + .test_ctl_val = 0x00000000,
> + .test_ctl_hi_val = 0x00000003,
> + .test_ctl_hi1_val = 0x00009000,
> + .test_ctl_hi2_val = 0x00000034,
> + .user_ctl_val = 0x00000400,
> + .user_ctl_hi_val = 0x00000005,
> +};
Since its a script that generates most of this code, can't you teach it
to enumerate these magic numbers with defines and bit-fields ?
I'm not sure if I got an answer to that question on the last iteration
of this patch but, asking again now.
---
bod
next prev parent reply other threads:[~2026-05-07 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 5:38 [PATCH v5 0/6] Add support for videocc and camcc on X1P42100 platform Jagadeesh Kona
2026-05-07 5:38 ` [PATCH v5 1/6] dt-bindings: clock: qcom: Add X1P42100 video clock controller Jagadeesh Kona
2026-05-07 5:38 ` [PATCH v5 2/6] dt-bindings: clock: qcom: Add X1P42100 camera " Jagadeesh Kona
2026-05-07 5:38 ` [PATCH v5 3/6] clk: qcom: videocc-x1p42100: Add support for video " Jagadeesh Kona
2026-05-07 5:38 ` [PATCH v5 4/6] clk: qcom: camcc-x1e80100: Add support for camera QDSS debug clocks Jagadeesh Kona
2026-05-07 5:38 ` [PATCH v5 5/6] clk: qcom: camcc-x1p42100: Add support for camera clock controller Jagadeesh Kona
2026-05-07 8:15 ` Bryan O'Donoghue [this message]
2026-05-08 4:10 ` Jagadeesh Kona
2026-05-07 5:38 ` [PATCH v5 6/6] arm64: dts: qcom: x1e80100: Add CAMCC block definition Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26191034-ad27-4559-a845-14841c075a4c@kernel.org \
--to=bod@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jkona@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox