From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: <Ryan.Wanner@microchip.com>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <alexandre.belloni@bootlin.com>,
<claudiu.beznea@tuxon.dev>
Cc: <linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: at91: clk-master: Add check for divide by 3
Date: Mon, 15 Sep 2025 16:54:57 +0200 [thread overview]
Message-ID: <272ffdb9-9d7f-4a48-9968-7de1d32d721e@microchip.com> (raw)
In-Reply-To: <1882cb12-cb65-423a-bacb-3965ba845ab3@microchip.com>
On 09/09/2025 at 09:57, Nicolas Ferre wrote:
> On 08/09/2025 at 22:07, Ryan.Wanner@microchip.com wrote:
>> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>>
>> A potential divider for the master clock is div/3. The register
>> configuration for div/3 is MASTER_PRES_MAX. The current bit shifting
>> method does not work for this case. Checking for MASTER_PRES_MAX will
>> ensure the correct decimal value is stored in the system.
>>
>> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Added to clk-microchip, on its way upstream.
Thanks, regards,
Nicolas
> Thanks Ryan, regards,
> Nicolas
>
>> ---
>> drivers/clk/at91/clk-master.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c
>> index 7a544e429d34..d5ea2069ec83 100644
>> --- a/drivers/clk/at91/clk-master.c
>> +++ b/drivers/clk/at91/clk-master.c
>> @@ -580,6 +580,9 @@ clk_sama7g5_master_recalc_rate(struct clk_hw *hw,
>> {
>> struct clk_master *master = to_clk_master(hw);
>>
>> + if (master->div == MASTER_PRES_MAX)
>> + return DIV_ROUND_CLOSEST_ULL(parent_rate, 3);
>> +
>> return DIV_ROUND_CLOSEST_ULL(parent_rate, (1 << master->div));
>> }
>>
>
prev parent reply other threads:[~2025-09-15 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 20:07 [PATCH] clk: at91: clk-master: Add check for divide by 3 Ryan.Wanner
2025-09-09 7:57 ` Nicolas Ferre
2025-09-15 14:54 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=272ffdb9-9d7f-4a48-9968-7de1d32d721e@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Ryan.Wanner@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox