From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.126.130]:59181 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbcKHPsP (ORCPT ); Tue, 8 Nov 2016 10:48:15 -0500 From: Arnd Bergmann To: "Y.B. Lu" Cc: "linuxppc-dev@lists.ozlabs.org" , "linux-mmc@vger.kernel.org" , "ulf.hansson@linaro.org" , Scott Wood , Mark Rutland , Greg Kroah-Hartman , "X.B. Xie" , "M.H. Lian" , "linux-i2c@vger.kernel.org" , "linux-clk@vger.kernel.org" , Qiang Zhao , Russell King , Bhupesh Sharma , Joerg Roedel , Claudiu Manoil , "devicetree@vger.kernel.org" , Rob Herring , Santosh Shilimkar , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Leo Li , "iommu@lists.linux-foundation.org" , Kumar Gala Subject: Re: [v15, 3/7] powerpc/fsl: move mpc85xx.h to include/linux/fsl Date: Tue, 08 Nov 2016 16:47:00 +0100 Message-ID: <2774358.lRZpWbmlT7@wuerfel> In-Reply-To: References: <1477637418-38938-1-git-send-email-yangbo.lu@nxp.com> <1543282.vWjeo4ynTa@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-clk-owner@vger.kernel.org List-ID: On Tuesday, November 8, 2016 6:49:51 AM CET Y.B. Lu wrote: > Hi Arnd, > > > > -----Original Message----- > > From: Arnd Bergmann [mailto:arnd@arndb.de] > > Sent: Tuesday, November 08, 2016 5:20 AM > > To: Y.B. Lu > > Cc: linuxppc-dev@lists.ozlabs.org; linux-mmc@vger.kernel.org; > > ulf.hansson@linaro.org; Scott Wood; Mark Rutland; Greg Kroah-Hartman; X.B. > > Xie; M.H. Lian; linux-i2c@vger.kernel.org; linux-clk@vger.kernel.org; > > Qiang Zhao; Russell King; Bhupesh Sharma; Joerg Roedel; Claudiu Manoil; > > devicetree@vger.kernel.org; Rob Herring; Santosh Shilimkar; linux-arm- > > kernel@lists.infradead.org; netdev@vger.kernel.org; linux- > > kernel@vger.kernel.org; Leo Li; iommu@lists.linux-foundation.org; Kumar > > Gala > > Subject: Re: [v15, 3/7] powerpc/fsl: move mpc85xx.h to include/linux/fsl > > > > On Monday, October 31, 2016 9:35:33 AM CET Y.B. Lu wrote: > > > > > > > > I don't see any of the contents of this header referenced by the soc > > > > driver any more. I think you can just drop this patch. > > > > > > > > > > [Lu Yangbo-B47093] This header file was included by guts.c. > > > The guts driver used macro SVR_MAJ/SVR_MIN for calculation. > > > > > > This header file was for powerpc arch before. And this patch is to > > > made it as common header file for both ARM and PPC. > > > Sooner or later this is needed. > > > > Let's discuss it once we actually need the header then, ok? > > [Lu Yangbo-B47093] As I said, this header file was included by guts.c in patch 4. Ah sorry, I misread your earlier reply, thinking you meant a potential future patch. > The guts driver used macro SVR_MAJ/SVR_MIN for calculation which were > defined in this header file. > Did you suggest we dropped this patch and just calculated them in driver? That is probably nicer here: there is not that much value in sharing the two one-line macro definitions, and the driver already hardcodes the numeric per-chip IDs that make up most of the header file. Arnd