Re: [PATCH v9 5/9] clk: mmp: Add Marvell PXA1908 clock driver

Stephen Boyd
2024-04-19T22:24:44Z

Quoting Duje Mihanović (2024-04-19 07:31:14)
> On Friday, April 12, 2024 4:57:09 AM GMT+2 Stephen Boyd wrote:
> > Quoting Duje Mihanović (2024-04-11 03:15:34)
> >
> > > On 4/11/2024 10:00 AM, Stephen Boyd wrote:
> > > > Is there a reason this file can't be a platform driver?
> > >
> > > Not that I know of, I did it like this only because the other in-tree
> > > MMP clk drivers do so. I guess the initialization should look like any
> > > of the qcom GCC drivers then?
> >
> > Yes.
>
> With the entire clock driver code in one file this is quite messy as I also
> needed to add module_init and module_exit functions to (un)register each
> platform driver, presumably because the module_platform_driver macro doesn't
> work with multiple platform drivers in one module. If I split up the driver
> code for each clock controller block into its own file (such as clk-of-
> pxa1908-apbc.c) as I believe is the best option, should the commits be split
> up accordingly as well?

Sure. Why is 'of' in the name? Maybe that is unnecessary?

>
> > > While at it, do you think the other MMP clk drivers could use a
> conversion?
> >
> > I'm a little wary if the conversion cannot be tested though.
>
> I'd rather leave it to someone with the hardware then, especially since the
> only reason I found out about the above is that the board I'm working on
> failed to boot completely without the module_init function.
>

Ok, sounds fine.