From: "Heiko Stübner" <heiko@sntech.de>
To: arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization.
Date: Wed, 24 Aug 2016 16:56:08 +0200 [thread overview]
Message-ID: <2854111.gibmD6ORig@diego> (raw)
In-Reply-To: <fa254e23-818c-0698-cbbc-68c983e83203@gmail.com>
Hi Arvind,
Am Mittwoch, 24. August 2016, 19:52:45 schrieb arvind Yadav:
> yes, I am referring this code for clock control.
Please definitly do not use that old gate driver anymore!
Instead please look at the real clock drivers for specific Rockchip soc=
s in the=20
same directory.
Which Rockchip soc are you working on?
Heiko
> On Tuesday 23 August 2016 09:45 PM, Heiko St=FCbner wrote:
> > Hi Arvind,
> >=20
> > Am Samstag, 13. August 2016, 20:56:18 schrieb Arvind Yadav:
> >> -check return of 'of_iomap'.if It's falied to remap then abort.
> >>=20
> >> -Unmap a region obtained by remap. iounmap frees the mapping when =
failed
> >> to allocate the memory.
> >>=20
> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> >> ---
> >>=20
> >> drivers/clk/rockchip/clk-rockchip.c | 7 ++++++-
> >=20
> > I've applied the patch, after rewording both patch subject and mess=
age
> > [0].
> >=20
> > That driver is deprecated for quite some time, see
> > Documenation/devicetree/bindings/clock/rockchip.txt - so I'm hoping=
this
> > is
> > more of a random find and you're not actually using it?
> >=20
> >=20
> > Thanks
> > Heiko
> >=20
> > [0]
> > https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.g=
it/com
> > mit/?id=3D023a8280b8355a0aebe094299afec8d8b7b264cd
prev parent reply other threads:[~2016-08-24 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 15:26 [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization Arvind Yadav
2016-08-23 16:15 ` Heiko Stübner
2016-08-24 14:22 ` arvind Yadav
2016-08-24 14:56 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2854111.gibmD6ORig@diego \
--to=heiko@sntech.de \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox