Re: [RFC PATCH v5 6/9] media: tegra: Add Tegra210 Video input driver

Sakari Ailus
2020-03-31T10:32:59Z

Hi Hans,

On Mon, Mar 30, 2020 at 12:59:15PM +0200, Hans Verkuil wrote:
> On 3/25/20 12:03 PM, Sakari Ailus wrote:
> > Hi Sowjanya,
> >
> > Thanks for the patchset.
> >
> > On Mon, Mar 23, 2020 at 10:52:32AM -0700, Sowjanya Komatineni wrote:
> >> Tegra210 contains a powerful Video Input (VI) hardware controller
> >> which can support up to 6 MIPI CSI camera sensors.
> >>
> >> Each Tegra CSI port can be one-to-one mapped to VI channel and can
> >> capture from an external camera sensor connected to CSI or from
> >> built-in test pattern generator.
> >>
> >> Tegra210 supports built-in test pattern generator from CSI to VI.
> >>
> >> This patch adds a V4L2 media controller and capture driver support
> >> for Tegra210 built-in CSI to VI test pattern generator.
> >>
> >> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> >> ---
> >> drivers/staging/media/Kconfig | 2 +
> >> drivers/staging/media/Makefile | 1 +
> >> drivers/staging/media/tegra/Kconfig | 10 +
> >> drivers/staging/media/tegra/Makefile | 8 +
> >> drivers/staging/media/tegra/TODO | 10 +
> >> drivers/staging/media/tegra/tegra-common.h | 263 +++++++
> >> drivers/staging/media/tegra/tegra-csi.c | 522 ++++++++++++++
> >> drivers/staging/media/tegra/tegra-csi.h | 118 ++++
> >> drivers/staging/media/tegra/tegra-vi.c | 1058 ++++++++++++++++++++++++++++
> >> drivers/staging/media/tegra/tegra-vi.h | 83 +++
> >> drivers/staging/media/tegra/tegra-video.c | 129 ++++
> >> drivers/staging/media/tegra/tegra-video.h | 32 +
> >> drivers/staging/media/tegra/tegra210.c | 754 ++++++++++++++++++++
> >> drivers/staging/media/tegra/tegra210.h | 192 +++++
> >
> > Why staging? Are there reasons not to aim this to the kernel proper right
> > away? If you only support TPG, the driver may not have too many (if any)
> > real users anyway.
> >
> >> 14 files changed, 3182 insertions(+)
> >> create mode 100644 drivers/staging/media/tegra/Kconfig
> >> create mode 100644 drivers/staging/media/tegra/Makefile
> >> create mode 100644 drivers/staging/media/tegra/TODO
> >> create mode 100644 drivers/staging/media/tegra/tegra-common.h
> >> create mode 100644 drivers/staging/media/tegra/tegra-csi.c
> >> create mode 100644 drivers/staging/media/tegra/tegra-csi.h
> >> create mode 100644 drivers/staging/media/tegra/tegra-vi.c
> >> create mode 100644 drivers/staging/media/tegra/tegra-vi.h
> >> create mode 100644 drivers/staging/media/tegra/tegra-video.c
> >> create mode 100644 drivers/staging/media/tegra/tegra-video.h
> >> create mode 100644 drivers/staging/media/tegra/tegra210.c
> >> create mode 100644 drivers/staging/media/tegra/tegra210.h
> >>
>
> <snip>
>
> >> +static int tegra_channel_g_input(struct file *file, void *priv,
> >> + unsigned int *i)
> >> +{
> >> + *i = 0;
> >> + return 0;
> >> +}
> >> +
> >> +static int tegra_channel_s_input(struct file *file, void *priv,
> >> + unsigned int input)
> >> +{
> >> + if (input > 0)
> >> + return -EINVAL;
> >> +
> >> + return 0;
> >> +}
> >
> > Please see patchset on topic "v4l2-dev/ioctl: Add V4L2_CAP_IO_MC" on
> > linux-media; it's relevant here, too.
>
> No, it isn't. The pipeline is controlled by the driver, not by userspace.
> This is a regular video capture driver, not an ISP driver.

I don't think that really makes a difference, whether a device is an ISP or
not, but instead what does is whether there is something to control in its
pipeline that cannot be generally done through the regular V4L2 interface.
Even plain CSI-2 receiver drivers should be media device centric these days
as doing otherwise excludes using a range of sensor drivers with them,
including any possible future support for e.g. sensor embedded data.

--
Kind regards,

Sakari Ailus