From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-sunxi@googlegroups.com, maxime.ripard@bootlin.com Cc: Jagan Teki , Chen-Yu Tsai , Icenowy Zheng , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel@lists.freedesktop.org, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Michael Trimarchi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [linux-sunxi] Re: [PATCH v4 1/4] clk: sunxi-ng: Enable DE2_CCU for SUN8I and SUN50I Date: Thu, 06 Sep 2018 07:10:06 +0200 Message-ID: <2955967.qdhifWMYUT@jernej-laptop> In-Reply-To: <20180905070335.dclhpxjld4vdkdu4@flea> References: <20180904163609.10171-1-jagan@amarulasolutions.com> <20180905070335.dclhpxjld4vdkdu4@flea> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" List-ID: Dne sreda, 05. september 2018 ob 09:03:35 CEST je Maxime Ripard napisal(a): > On Tue, Sep 04, 2018 at 10:06:06PM +0530, Jagan Teki wrote: > > Allwinner SoC like SUN8I and SUN50I has DE2 CCU so enable them > > as default. > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v4, v3: > > - none > > Changes for v2: > > - Enable for MACH_SUN8I > > > > drivers/clk/sunxi-ng/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig > > index 826674d090fd..e20182aa9748 100644 > > --- a/drivers/clk/sunxi-ng/Kconfig > > +++ b/drivers/clk/sunxi-ng/Kconfig > > @@ -63,6 +63,8 @@ config SUN8I_V3S_CCU > > > > config SUN8I_DE2_CCU > > > > bool "Support for the Allwinner SoCs DE2 CCU" > > > > + default MACH_SUN8I || (ARM64 && ARCH_SUNXI) > > + depends on DRM_SUN4I && (MACH_SUN8I || (ARM64 && ARCH_SUNXI)) > > I don't see why there's a dependency on the DRM driver. I'm pretty > sure this would even break simplefb. I think best approach would be that SUN8I_MIXER selects (or depends on?) this symbol, since it can't work if there is no DE2 CCU clock present. Best regards, Jernej