public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
To: Jon Hunter <jonathanh@nvidia.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Ajit Pandey <quic_ajipan@quicinc.com>,
	"Imran Shaik" <quic_imrashai@quicinc.com>,
	Taniya Das <quic_tdas@quicinc.com>,
	Jagadeesh Kona <quic_jkona@quicinc.com>,
	kernel test robot <lkp@intel.com>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] clk: qcom: clk-alpha-pll: Replace divide operator with comparison
Date: Thu, 5 Sep 2024 16:28:20 +0530	[thread overview]
Message-ID: <29874390-2c8b-400a-9034-cccb929346a2@quicinc.com> (raw)
In-Reply-To: <5b24f86a-b2cc-4c36-aa2f-2a01cbae12fa@nvidia.com>

Hi Jon,


>>>>
>>>> remainder = do_div(rate, prate);
>>>>
>>>>> -    if ((remainder * 2) / prate)
>>>>> +    if ((remainder * 2) >= prate)
>>>>>           *l = *l + 1;
>>>>
>>>> *l = rate + (u32)(remainder * 2 >= prate);
>>>
>>>
>>> The above change does fix this build error for me.
>>>
>>> Satya, did you intend this to be a fix? Can we get this into -next?
>>>
>>
>> Yes, I have posted a v2 for this last week, but there are few open 
>> comments on that, I'll address them and post V3 including the build 
>> error you reported in commit-text.
>>
>>
>> [v2] 
>> https://lore.kernel.org/linux-clk/20240814102005.33493-1-quic_skakitap@quicinc.com/
>
>
> Have you push a V3 yet?


Not yet Jon, I had a query regarding Bjorn's comment where he mentioned 
the patch wouldn't compile on arm32 target, I am trying to check that 
with him. Once I get the details I'll make the changes accordingly and 
post V3.


Thanks,

Satya priya


  reply	other threads:[~2024-09-05 10:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13  9:40 [PATCH] clk: qcom: clk-alpha-pll: Replace divide operator with comparison Satya Priya Kakitapalli
2024-08-13 20:01 ` Vladimir Zapolskiy
2024-08-28 13:47   ` Jon Hunter
2024-08-28 20:44     ` Dmitry Baryshkov
2024-08-29  9:14       ` Dan Carpenter
2024-08-30  5:33     ` Satya Priya Kakitapalli
2024-09-04 21:26       ` Jon Hunter
2024-09-05 10:58         ` Satya Priya Kakitapalli [this message]
2024-09-06 11:07   ` Satya Priya Kakitapalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29874390-2c8b-400a-9034-cccb929346a2@quicinc.com \
    --to=quic_skakitap@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mturquette@baylibre.com \
    --cc=quic_ajipan@quicinc.com \
    --cc=quic_imrashai@quicinc.com \
    --cc=quic_jkona@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=sboyd@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox