From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7957D225414; Thu, 8 May 2025 12:37:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746707824; cv=none; b=FrYGuz93a4lDdaA/Rx1fth4Vak5dUZZCGxGLxXRqsv8uJ+zOYd0WJ0gBVwgX6aLeW15UT4zEitsIpR5hFywog0icDg3g1NVP6tViW5GcL/TxvCv9giSuRL0qLchn4qgh/MxNlvqOec7El1Uvu7iBre0N8I14maTOBdrGD1tfY6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746707824; c=relaxed/simple; bh=uf04WvtBTAcu8i+qtx/QIct6W3coW9VBYJe7IqLhV2o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PgCg9W4inFsICWYxTWCecW4IEj4qlRoqrb1uu4wQ0Z9OtpQ82mPAsnj4twX/fbA+a8AgUdL9dkPGtuN+E51eLwUyy5lTvR1tbhh+AfULpjwEGhuHapqOhJcvK21v2dBJa8RVM7ze+Pq6g2PpXyhMlHw6vEdOIj2xbqS6HugYxIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IRJI7sXU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IRJI7sXU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 842DEC4CEE7; Thu, 8 May 2025 12:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746707823; bh=uf04WvtBTAcu8i+qtx/QIct6W3coW9VBYJe7IqLhV2o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IRJI7sXUUKmI6ml+03g/Xm8u/BTPBl5SxN3Yed3TQsdsIVV4mk1vFrjhcLjyD+9Xo t9B1sU06ki4/bdSxAQ7TG8sMz+VpvGxWupwpefs67sgj3tqO4QprZrwTwyBn3mPNAu /hcQrsKbGckuiIGXLvklOKpuKd/eEdd1m9NRMJRC84ZnQpmgoY8D86enFLmkb1jqpn mBqueOzpGpOwz5AE6P6YR2qZb8ZKzQptDXFWAthNcBR0P5arHHvtkhuc6vFa02dyH3 QqdzXL6y4tR/KEOVRkA9NQbNs2UrpHl/Ukltr+tScVZdOEbDdLfnc/d1mm8aZun+38 KrFX0c9m2rSsg== Message-ID: <2ce8b9e5-562e-454f-9e2b-f2796d309063@kernel.org> Date: Thu, 8 May 2025 14:36:57 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/6] dt-bindings: soc: spacemit: define spacemit,k1-ccu resets To: Alex Elder , Yixun Lan Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, heylenay@4d2.org, inochiama@outlook.com, guodong@riscstar.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20250506210638.2800228-1-elder@riscstar.com> <20250506210638.2800228-2-elder@riscstar.com> <20250507223554-GYA505240@gentoo> <22b7b5fc-6f5a-4ce8-ae12-a7423925c113@kernel.org> <1521c828-31f3-4e45-a651-750ce2e37364@riscstar.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <1521c828-31f3-4e45-a651-750ce2e37364@riscstar.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08/05/2025 14:17, Alex Elder wrote: > On 5/8/25 7:02 AM, Krzysztof Kozlowski wrote: >> On 08/05/2025 00:35, Yixun Lan wrote: >>>> + - if: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + enum: >>>> + - spacemit,k1-syscon-apbc >>>> + - spacemit,k1-syscon-apmu >>>> + - spacemit,k1-syscon-mpmu >>>> + then: >>>> + required: >>>> + - clocks >>>> + - clock-names >>>> + - "#clock-cells" >>>> >>>> additionalProperties: false >>>> >>>> diff --git a/include/dt-bindings/clock/spacemit,k1-syscon.h b/include/dt-bindings/clock/spacemit,k1-syscon.h >>>> index 35968ae982466..f5965dda3b905 100644 >>>> --- a/include/dt-bindings/clock/spacemit,k1-syscon.h >>>> +++ b/include/dt-bindings/clock/spacemit,k1-syscon.h >>> would it be better to move all reset definition to its dedicated dir? >>> which like: include/dt-bindings/reset/spacemit,k1-syscon.h? >> >> Please kindly trim the replies from unnecessary context. It makes it >> much easier to find new content. >> >> >> I don't get why such comments are appearing so late - at v6. There was >> nothing from you about this in v1, v2 and v3, which finally got reviewed. > > Stephen Boyd said "please rework this to use the auxiliary driver > framework" on version 5 of the series; it was otherwise "done" at > that point. Stephen is a subsystem maintainer so his comments are fine or acceptable to be late. > > Doing this meant there was a much clearer separation of the clock > definitions from the reset definitions. And Yixun's suggestion > came from viewing things in that context. Weren't they applicable to v1 as well? How bindings could change with change to auxiliary bus/driver? > > Given the rework, I considered sending this as v1 of a new series > but did not. Sorry but no. Bindings headers at v1 are exactly the same or almost the same as now: https://lore.kernel.org/lkml/20250321151831.623575-2-elder@riscstar.com/ so this idea could have been given at v1, v2, v3, v4, v5 (that would be late).... but at some point this is just unnecessary late nitpicking. So what then? Imagine that you prepare v7 and some other person gives you different comment about bindings or bindings headers. Then you prepare v8. And then someone comes with one more, different comment, because that person did not bother to review between v1-v8 (that imaginary future v8), so you need to prepare v9. I don't think this process is correct. Best regards, Krzysztof