Re: [PATCH 2/2] clk: qcom: Introduce SM8350 VIDEOCC

Konrad Dybcio
2023-04-14T11:10:36Z

On 14.04.2023 05:27, Bjorn Andersson wrote:
> On Thu, Apr 13, 2023 at 08:44:59PM +0200, Konrad Dybcio wrote:
>> diff --git a/drivers/clk/qcom/videocc-sm8350.c b/drivers/clk/qcom/videocc-sm8350.c
> [..]
>> +static struct clk_alpha_pll video_pll0 = {
>> + .offset = 0x42c,
>> + .vco_table = lucid_5lpe_vco,
>> + .num_vco = ARRAY_SIZE(lucid_5lpe_vco),
>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID],
>> + .clkr = {
>> + .hw.init = &(struct clk_init_data){
>
> I know it's tiny, but please add a <space> between ) and { of these.
Sure!

>
>> + .name = "video_pll0",
>> + .parent_data = &(const struct clk_parent_data){
>> + .index = DT_BI_TCXO,
>> + },
>> + .num_parents = 1,
>> + .ops = &clk_alpha_pll_lucid_5lpe_ops,
>> + },
>> + },
>> +};
> [..]
>> +
>> +static int __init video_cc_sm8350_init(void)
>> +{
>> + return platform_driver_register(&video_cc_sm8350_driver);
>> +}
>> +subsys_initcall(video_cc_sm8350_init);
>
> You don't need this at subsys_initcall(), please use
> module_platform_driver().
Right, we don't need to decode console boot logs..

Konrad
>
> Thanks,
> Bjorn