Re: [RFC PATCH 2/3] clk: adjust clocks to their requested rate after parent changes

Doug Anderson
2016-05-06T00:49:39Z

Hi,

On Thu, May 5, 2016 at 5:35 PM, Doug Anderson <dianders@chromium.org> wrote:
> I guess we don't care about errors here?
>
> ...maybe (?) we could ignore errors if we validated this rate change
> with PRE_RATE_CHANGE before attempting to change the parent clock, but
> I don't see the code doing this unless I missed it.

One other related thought: it seems like there should be code
_somewhere_ that decides whether to adjust the child dividers before
or after the parent clock changes. Specifically if the parent clock
is increasing in speed we probably want to slow down the child clock
ahead of the parent's increase. I don't see such code here, but again
I'm pretty good at missing things unless they are slapping me in the
face. ;)

-Doug