From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A95234CFD0 for ; Mon, 16 Mar 2026 07:19:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773645547; cv=none; b=Ly1YBGtUyCpv/Zf7uFixs2AUC1McLt5K7RKpExyeC32XbkZgpswZGujHXQb5GbynDsYo8eLBZonDlwJbtj7oG5L0WlYcZtXoUs9Z1pX36+XBoXxsmO5PZVE9E6jlUj+Ed+s5gxr5SDN5qPTpKJORKxPZmZJiVA0CWFygfS7yACM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773645547; c=relaxed/simple; bh=j8v8ld7zJoZ9UjhL+Y57qItIiIfZVj2JTddzfGquieI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QWkKCB7vh0Mtt4nlVHJxnlKLJv736Rej6cXZrayym9DbgJTprcWR1ZqbQvaaUXGhSCxIsgNCG65VhtZvTuTTGYdVBrMTQ3Q/0iSEkuqshw9ty7cgZiyAldHHWmzNl4dJx5UZ3fGKIcIOdFxnppBEFlYisJB4tCKtLSfcxgNaxcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pLedPCbI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hScF2Ru6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pLedPCbI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hScF2Ru6" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G64hQW323609 for ; Mon, 16 Mar 2026 07:19:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9XNQwagjQvS1eX8YPd1QfF/D3gxhUMNjfLGG0HuA04A=; b=pLedPCbIxWA7k0aE j/AH2ZN0Xz4dlUErhfkoEASMaztd60FdpVtZKk4rRP6nGM5o4U8a5u4TpJP5tHoe CGaPRdPf00qvgRg+fQpIJlJg2xyFVkXEAODPA1Vck4F5ZN0qvY3YXKCwQxnqSYd+ 8GuM36SO4VVpLxNqB2D3hgBvbGvNi5i2pfF2lMdo8UObuoZ7uBertxReEk7dhTu7 wZOhAhCCw6wNv4H6ct9J7475v6kZZ07wsiNBTLyViMdDjBb1om3NU6MVrevpdJxY HY0IT98gSrTEYM/wG7ojVnAuuGCiD3vBl3TnEZpdUedjKuGF14W3DWZBhxc6gFHE 60ScgA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cw03qmmw5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 07:19:05 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82a0071f14eso28479408b3a.2 for ; Mon, 16 Mar 2026 00:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773645544; x=1774250344; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9XNQwagjQvS1eX8YPd1QfF/D3gxhUMNjfLGG0HuA04A=; b=hScF2Ru6z5B9/Lvgs75NImvnG8fAwrPYa0oNfVKLbgNqP0q+NSIKk6ngCfKQ6X+0OV RiDAGneBi7RtZNGLWZ8oabqMkSU2o+TnPsxm07XZ4JyqmsNmuLzp5nMhJmT42qSD1sSz k6xiwR6g9WJClhB7obqHLODhRc2kdIzm3gJXgYn1zwcQpJ70Sd12qsj7MQFuL7S6mo/A FKS/uCSDh8lASSKW45TwSTkQaGV0sikzrYLZxmPAnalTJCtyBIl/Bo/zJ8Qe7AvyH17W sm8nPI6AE0XzGBFmQEhtq7swECGZlqHzr1QEmmRZ9IYKres5k7G/zf3ojtqUbXAsKxmu 6cdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773645544; x=1774250344; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9XNQwagjQvS1eX8YPd1QfF/D3gxhUMNjfLGG0HuA04A=; b=T9HZRWir8zwoQKmlkuM16UPEaV3FFGR65WTVievAZuWJJLGelY8xf5rCPAe3o5CaqX G0gYIZxfAG94ownqitUqe1H5qoVHnwol+riealJq1MKiFa1wK2GzwrECKWHgZ1wV6bbQ EjsW4ig75rjlsMS2tkzxRtURd6ezCWQJs/C1M79wvb+VPdIiXGsMf1tUSfREHPSXIUli ulZTRJxKdK8GQCchB8rOXOrBY579KCLLU2/HCbf2okU78+3A++6vn4Fh0RK4/83zQ4Zm QX3NCNznVt2j5oxmvzZdjAMji6VagMHnktr3Ljet/JrNY0LWG7gNcFO1XGGvkgRPOQWc UKYw== X-Forwarded-Encrypted: i=1; AJvYcCXcm7PIbBYzt8/n3cM+3s0efx+VkVL4bpobB1lUFmp66LLpyRBU65bSj4yZMavCpgF3NaPYA/eLiLg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6zO8XT8bHLfKykX8NdWASC24h7NKOYGdINrmHEZ9Ou/XC/8im B37T/fejpndYVP3DbdnG3FZBVkN0MYlOJ7R783vx4WWaIs/OuHr8A0bdJ8C6cg1uiRbcS6yfYHS +E7pIYNjvpxr05KuhbwA8+eyVuCy3mL4QeP/I4rqxxP2RrEOl/HlwDmaolG8bbA0= X-Gm-Gg: ATEYQzwRIRzakKAC3GgQ7Jx7/Nw4prc2FmjZkG95yVow7Mos9osglhVXJGgLUdbq9ua VDkTBNNS6qouivjan7IaS/HCtGja5qq21IeBOL5ELUejB22Ie9Vtrahegjh76t1yjjvBjr2kZrj 36+WWhRjn0D8RyBL5oni8lALeg/8PyoE31GombJ46xoMbqmKU87IScJz9iaZ0CCob3KS2SMuewB QioyLI3Cyw+exRzlZzX/nkCuP7cqvL7P2+/dFqGwvC/e1AMvedI/y8gB5i9ezpoyPG6ZDSli+Fj Y17ol4RnuektKCek3Y/FbP9TmyaFNLcdg5KqZdtzEbb8h9wkQEsXuleNGP7jgKsBWPnEygf7+3p jiuu03ySVEg3LaVi9auliekqxwMPcjnfscrY0iub/J5QOsiEq0Wjba4s6sM6uOOQ7GQ== X-Received: by 2002:a05:6a00:2989:b0:82a:ea3:c174 with SMTP id d2e1a72fcca58-82a1993b643mr10389524b3a.56.1773645544034; Mon, 16 Mar 2026 00:19:04 -0700 (PDT) X-Received: by 2002:a05:6a00:2989:b0:82a:ea3:c174 with SMTP id d2e1a72fcca58-82a1993b643mr10389496b3a.56.1773645543599; Mon, 16 Mar 2026 00:19:03 -0700 (PDT) Received: from [10.151.37.217] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a0727e581sm11875787b3a.27.2026.03.16.00.18.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 00:19:03 -0700 (PDT) Message-ID: <309abcd9-3baa-4fa5-830e-c9d36b6890c3@oss.qualcomm.com> Date: Mon, 16 Mar 2026 12:48:56 +0530 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/9] dt-bindings: pinctrl: qcom: add IPQ5210 pinctrl To: Krzysztof Kozlowski Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Linus Walleij , Konrad Dybcio , Ulf Hansson , Robert Marko , Guru Das Srinagesh , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-mmc@vger.kernel.org References: <20260311-ipq5210_boot_to_shell-v1-0-fe857d68d698@oss.qualcomm.com> <20260311-ipq5210_boot_to_shell-v1-3-fe857d68d698@oss.qualcomm.com> <20260313-primitive-talented-boobook-d7a7e7@quoll> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: <20260313-primitive-talented-boobook-d7a7e7@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: q92lCu2YlgzDx5aO-LUoXGOE82lAKXER X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA1NCBTYWx0ZWRfX6OBMTELDA/1K 6mImqWf1vXYJyq4blOH0VrO5yj/zBXiqdkKCBZJPLHc+B1BMcB3vg8ieJ0sa+EF70MWtQtctEcy KDSvzmFjuKNqPXsukYSsCmaX3KMdzoe6OoTEx6j2hCa6bDwYzTGpEzhGWWCOAW1hFgfBBqBQzu4 jImq5G/geZZskqfTn+cUJRY4va9EQF5lBlsmElgplGpfK5okQm8kP/s59nXKxxN9gLORexotCQL 3KtniNyj1VFXaKDryvq0mYooNN2HC5lDVYMvOT7fliKtkdY3B66QkSbmxEMtwMfhP2/FdlBhvDm zdQdpnxtdgq+zQ72DeDhY/GsVcVS5Yy5EvbzKJjqZySLRIOk7QfpcUwYtm8dPwOADNImNuglvOk Ysgs4+H7otCW7w9EYBL03GxNrRiScyQnm6OET+DkWO9X6yeCr+zFOEmH3h892FHeD6Ut4ridlNR 3ORuxkipcWC+2SmYFUQ== X-Proofpoint-ORIG-GUID: q92lCu2YlgzDx5aO-LUoXGOE82lAKXER X-Authority-Analysis: v=2.4 cv=ZbQQ98VA c=1 sm=1 tr=0 ts=69b7aee9 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=4YdXfc-GfyRXmrUFxqYA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_03,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 adultscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160054 On 3/13/2026 6:54 PM, Krzysztof Kozlowski wrote: > On Wed, Mar 11, 2026 at 03:15:45PM +0530, Kathiravan Thirumoorthy wrote: >> Add device tree bindings for IPQ5210 TLMM block. >> >> Signed-off-by: Kathiravan Thirumoorthy >> --- >> .../bindings/pinctrl/qcom,ipq5210-tlmm.yaml | 141 +++++++++++++++++++++ >> 1 file changed, 141 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq5210-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq5210-tlmm.yaml >> new file mode 100644 >> index 0000000000000000000000000000000000000000..3e5a46638385cf7925963c7e4b615c67e642152c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq5210-tlmm.yaml >> @@ -0,0 +1,141 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pinctrl/qcom,ipq5210-tlmm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm IPQ5210 TLMM pin controller >> + >> +maintainers: >> + - Bjorn Andersson >> + - Kathiravan Thirumoorthy >> + >> +description: | > Drop | Ack. > > Please do not combine completely independent series, targetting > different subsystems, into one patchset. It does not bring benefits but > only make everything trickier for maintainers which need to figure out > dependencies and cherry pick instead of applying entire series. > > We raised this multiple times and it IS documented in your guideline, so > READ the internal docs. Ack. > >> + Top Level Mode Multiplexer pin controller in Qualcomm IPQ5210 SoC. >> + >> +allOf: >> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# >> + > ... > >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + tlmm: pinctrl@1000000 { >> + compatible = "qcom,ipq5210-tlmm"; >> + reg = <0x01000000 0x300000>; >> + gpio-controller; >> + #gpio-cells = <0x2>; >> + gpio-ranges = <&tlmm 0 0 54>; >> + interrupts = ; >> + interrupt-controller; >> + #interrupt-cells = <0x2>; >> + >> + qup-uart1-default-state { >> + tx-pins { >> + pins = "gpio39"; >> + function = "qup_se1_l2"; >> + drive-strength = <6>; >> + bias-pull-down; >> + }; >> + >> + rx-pins { >> + pins = "gpio38"; >> + function = "qup_se1_l3"; >> + drive-strength = <6>; >> + bias-pull-down; >> + }; >> + }; >> + > Drop blank line Ack. > > Reviewed-by: Krzysztof Kozlowski Thanks! > > Best regards, > Krzysztof >