Re: [PATCH -next] clk: sunxi-ng: Modify mismatched function name

Randy Dunlap
2023-07-22T14:31:42Z

On 7/22/23 08:31, Zhang Jianhua wrote:
> No functional modification involved.
>
> drivers/clk/sunxi-ng/ccu_mmc_timing.c:54: warning: expecting prototype for sunxi_ccu_set_mmc_timing_mode(). Prototype was for sunxi_ccu_get_mmc_timing_mode() instead
>
> Fixes: f6f64ed868d3 ("clk: sunxi-ng: Add interface to query or configure MMC timing modes.")
> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.

> ---
> drivers/clk/sunxi-ng/ccu_mmc_timing.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu_mmc_timing.c b/drivers/clk/sunxi-ng/ccu_mmc_timing.c
> index 23a8d44e2449..78919d7843be 100644
> --- a/drivers/clk/sunxi-ng/ccu_mmc_timing.c
> +++ b/drivers/clk/sunxi-ng/ccu_mmc_timing.c
> @@ -43,7 +43,7 @@ int sunxi_ccu_set_mmc_timing_mode(struct clk *clk, bool new_mode)
> EXPORT_SYMBOL_GPL(sunxi_ccu_set_mmc_timing_mode);
>
> /**
> - * sunxi_ccu_set_mmc_timing_mode: Get the current MMC clock timing mode
> + * sunxi_ccu_get_mmc_timing_mode: Get the current MMC clock timing mode
> * @clk: clock to query
> *
> * Return: %0 if the clock is in old timing mode, > %0 if it is in

--
~Randy