From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D099C2BA83 for ; Wed, 12 Feb 2020 12:04:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E7B32073C for ; Wed, 12 Feb 2020 12:04:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727613AbgBLMES (ORCPT ); Wed, 12 Feb 2020 07:04:18 -0500 Received: from gloria.sntech.de ([185.11.138.130]:35254 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727589AbgBLMER (ORCPT ); Wed, 12 Feb 2020 07:04:17 -0500 Received: from p508fd8fe.dip0.t-ipconnect.de ([80.143.216.254] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1j1qkU-0007ts-5l; Wed, 12 Feb 2020 13:04:10 +0100 From: Heiko Stuebner To: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, christoph.muellner@theobroma-systems.com, zhangqing@rock-chips.com, robin.murphy@arm.com Subject: Re: [PATCH v3 1/3] clk: rockchip: convert rk3399 pll type to use readl_poll_timeout Date: Wed, 12 Feb 2020 13:04:09 +0100 Message-ID: <3214502.EbdgFk5LkT@phil> In-Reply-To: <20200129163821.1547295-1-heiko@sntech.de> References: <20200129163821.1547295-1-heiko@sntech.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Am Mittwoch, 29. Januar 2020, 17:38:19 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > Instead of open coding the polling of the lock status, use the > handy readl_poll_timeout for this. As the pll locking is normally > blazingly fast and we don't want to incur additional delays, we're > not doing any sleeps similar to for example the imx clk-pllv4 > and define a very safe but still short timeout of 1ms. > > Suggested-by: Stephen Boyd > Signed-off-by: Heiko Stuebner applied all 3 for 5.7 with Stephen's Review