Re: [linux-sunxi] Re: [PATCH 2/3] clk: sunxi-ng: add support for PRCM CCUs

Re: [linux-sunxi] Re: [PATCH 2/3] clk: sunxi-ng: add support for PRCM CCUs

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 573 bytes --]

On Wed, Mar 01, 2017 at 08:17:39PM +0800, Icenowy Zheng wrote:
> > I'm a bit worried by that to be honest. You claim to support the A31, 
> > yet jugdging by the current state of that code you never actually 
> > tested it on that SoC. 
> 
> I only claim to reserve possibility to extend the driver to support
> A31, but I didn't claim it currently support A31.

Well, you did call it sun6i.

Please rename it, and we will consolidate in due time.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-sunxi] Re: [PATCH 2/3] clk: sunxi-ng: add support for PRCM CCUs

[Icenowy Zheng]

CgowMi4wMy4yMDE3LCAyMjowOSwgIk1heGltZSBSaXBhcmQiIDxtYXhpbWUucmlwYXJkQGZyZWUt
ZWxlY3Ryb25zLmNvbT46Cj4gT24gV2VkLCBNYXIgMDEsIDIwMTcgYXQgMDg6MTc6MzlQTSArMDgw
MCwgSWNlbm93eSBaaGVuZyB3cm90ZToKPj4gwqA+IEknbSBhIGJpdCB3b3JyaWVkIGJ5IHRoYXQg
dG8gYmUgaG9uZXN0LiBZb3UgY2xhaW0gdG8gc3VwcG9ydCB0aGUgQTMxLAo+PiDCoD4geWV0IGp1
Z2RnaW5nIGJ5IHRoZSBjdXJyZW50IHN0YXRlIG9mIHRoYXQgY29kZSB5b3UgbmV2ZXIgYWN0dWFs
bHkKPj4gwqA+IHRlc3RlZCBpdCBvbiB0aGF0IFNvQy4KPj4KPj4gwqBJIG9ubHkgY2xhaW0gdG8g
cmVzZXJ2ZSBwb3NzaWJpbGl0eSB0byBleHRlbmQgdGhlIGRyaXZlciB0byBzdXBwb3J0Cj4+IMKg
QTMxLCBidXQgSSBkaWRuJ3QgY2xhaW0gaXQgY3VycmVudGx5IHN1cHBvcnQgQTMxLgo+Cj4gV2Vs
bCwgeW91IGRpZCBjYWxsIGl0IHN1bjZpLgo+Cj4gUGxlYXNlIHJlbmFtZSBpdCwgYW5kIHdlIHdp
bGwgY29uc29saWRhdGUgaW4gZHVlIHRpbWUuCgpUaGVuIHJlbmFtZSBpdCBiYWNrIHdoZW4gaXQg
cmVhbGx5IGdhaW5zIHN1cHBvcnQgZm9yIEEzMT8KCj4KPiBNYXhpbWUKPgo+IC0tCj4gTWF4aW1l
IFJpcGFyZCwgRnJlZSBFbGVjdHJvbnMKPiBFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2lu
ZWVyaW5nCj4gaHR0cDovL2ZyZWUtZWxlY3Ryb25zLmNvbQoKX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK
bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl
YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=

Re: [linux-sunxi] Re: [PATCH 2/3] clk: sunxi-ng: add support for PRCM CCUs

[Icenowy Zheng]

CgowMi4wMy4yMDE3LCAyMjowOSwgIk1heGltZSBSaXBhcmQiIDxtYXhpbWUucmlwYXJkQGZyZWUt
ZWxlY3Ryb25zLmNvbT46Cj4gT24gV2VkLCBNYXIgMDEsIDIwMTcgYXQgMDg6MjI6MTNQTSArMDgw
MCwgSWNlbm93eSBaaGVuZyB3cm90ZToKPj4gwqA+IEknbSBhIGJpdCB3b3JyaWVkIGJ5IHRoYXQg
dG8gYmUgaG9uZXN0LiBZb3UgY2xhaW0gdG8gc3VwcG9ydCB0aGUgQTMxLAo+PiDCoD4geWV0IGp1
Z2RnaW5nIGJ5IHRoZSBjdXJyZW50IHN0YXRlIG9mIHRoYXQgY29kZSB5b3UgbmV2ZXIgYWN0dWFs
bHkKPj4gwqA+IHRlc3RlZCBpdCBvbiB0aGF0IFNvQy4KPj4gwqA+Cj4+IMKgPiBXaGF0IG1ha2Vz
IHlvdSBzYXkgdGhhdCB0aGUgUFJDTSBjbG9ja3MgYXJlIHRoZSBzYW1lIGZvciB0aGUgSDMgYW5k
Cj4+IMKgPiBBNjQ/IFdlIGhhdmUgdG8gYmUgc3VyZSwgb3RoZXJ3aXNlIHdlIG1pZ2h0IG5vdCBi
ZSBhYmxlIHRvIGdldCB0aGUgRFQKPj4gwqA+IGJpbmRpbmcgcmlnaHQgZnJvbSB0aGUgdmVyeSBi
ZWdpbm5pbmcsIGFuZCB3ZSBtaWdodCBub3QgYmUgYWJsZSB0byBmaXgKPj4gwqA+IGl0IGxhdGVy
Lgo+Pgo+PiDCoEluIGZhY3QsIGlmIHdlIHdvcnJ5IGFib3V0IHRoaXMsIHdlIHNob3VsZG4ndCBt
YWtlIHItY2N1LCBhcwo+PiDCoGRlZGljYXRlZCBjbG9ja3MgYXJlIG1vcmUgZWFzeSB0byBmaXgu
Cj4+Cj4+IMKgRm9yIG5ld2VyIFNvQ3MnIFBSQ00sIHdlIG5ldmVyIGhhdmUgZW5vdWdoIGRvY3Vt
ZW50cywgYW5kIEFsbHdpbm5lcgo+PiDCoGhhdmUgc2FpZCB0aGF0IHRoZXkgY2Fubm90IHByb3Zp
ZGUgaXQuIChJIGFza2VkIHRoZW0gZm9yIHRoaXMuKQo+Pgo+PiDCoFRoZSBiZXN0IHNvbHV0aW9u
IGlzIHRvIGltcGxlbWVudCBtYXR1cmUgZW5vdWdoIGRlZGljYXRlZCBjbG9ja3MKPj4gwqBiZWZv
cmUgd2UgY29udmVydCB0byBjY3UuCj4KPiBXaGF0IGRvIHlvdSBtZWFuIGJ5IGRlZGljYXRlZCBj
bG9ja3M/CgpUaGUgbGVnYWN5IGZvcm0gb2YgY2xvY2tzLgoKPgo+IE1heGltZQo+Cj4gLS0KPiBN
YXhpbWUgUmlwYXJkLCBGcmVlIEVsZWN0cm9ucwo+IEVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwg
ZW5naW5lZXJpbmcKPiBodHRwOi8vZnJlZS1lbGVjdHJvbnMuY29tCj4KPiAtLQo+IFlvdSByZWNl
aXZlZCB0aGlzIG1lc3NhZ2UgYmVjYXVzZSB5b3UgYXJlIHN1YnNjcmliZWQgdG8gdGhlIEdvb2ds
ZSBHcm91cHMgImxpbnV4LXN1bnhpIiBncm91cC4KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMg
Z3JvdXAgYW5kIHN0b3AgcmVjZWl2aW5nIGVtYWlscyBmcm9tIGl0LCBzZW5kIGFuIGVtYWlsIHRv
IGxpbnV4LXN1bnhpK3Vuc3Vic2NyaWJlQGdvb2dsZWdyb3Vwcy5jb20uCj4gRm9yIG1vcmUgb3B0
aW9ucywgdmlzaXQgaHR0cHM6Ly9ncm91cHMuZ29vZ2xlLmNvbS9kL29wdG91dC4KCl9fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg
bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v
bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK

Re: [linux-sunxi] Re: [PATCH 2/3] clk: sunxi-ng: add support for PRCM CCUs

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 829 bytes --]

On Thu, Mar 02, 2017 at 11:13:18PM +0800, Icenowy Zheng wrote:
> 
> 
> 02.03.2017, 22:09, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > On Wed, Mar 01, 2017 at 08:17:39PM +0800, Icenowy Zheng wrote:
> >>  > I'm a bit worried by that to be honest. You claim to support the A31,
> >>  > yet jugdging by the current state of that code you never actually
> >>  > tested it on that SoC.
> >>
> >>  I only claim to reserve possibility to extend the driver to support
> >>  A31, but I didn't claim it currently support A31.
> >
> > Well, you did call it sun6i.
> >
> > Please rename it, and we will consolidate in due time.
> 
> Then rename it back when it really gains support for A31?

Yes.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-sunxi] Re: [PATCH 2/3] clk: sunxi-ng: add support for PRCM CCUs

[maxime.ripard]

[-- Attachment #1.1: Type: text/plain, Size: 1550 bytes --]

On Thu, Mar 02, 2017 at 11:13:53PM +0800, Icenowy Zheng wrote:
> 
> 
> 02.03.2017, 22:09, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > On Wed, Mar 01, 2017 at 08:22:13PM +0800, Icenowy Zheng wrote:
> >>  > I'm a bit worried by that to be honest. You claim to support the A31,
> >>  > yet jugdging by the current state of that code you never actually
> >>  > tested it on that SoC.
> >>  >
> >>  > What makes you say that the PRCM clocks are the same for the H3 and
> >>  > A64? We have to be sure, otherwise we might not be able to get the DT
> >>  > binding right from the very beginning, and we might not be able to fix
> >>  > it later.
> >>
> >>  In fact, if we worry about this, we shouldn't make r-ccu, as
> >>  dedicated clocks are more easy to fix.
> >>
> >>  For newer SoCs' PRCM, we never have enough documents, and Allwinner
> >>  have said that they cannot provide it. (I asked them for this.)
> >>
> >>  The best solution is to implement mature enough dedicated clocks
> >>  before we convert to ccu.
> >
> > What do you mean by dedicated clocks?
> 
> The legacy form of clocks.

Which itself creates another form of issues. What happens if we get
something wrong on those clocks (as it is likely to happen)?

We potentially can't fix it at all, that's what happens.

And that's leaving aside the DT and clocks maintainers regular
complaints that we should get away from those.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel